Merge pull request #247 from mirumee/rename_invalid_response_error

Rename invalid response error
mirumee · Dec 4, 2023 · 79ad7fc · 79ad7fc
2 parents a30d1b0 + 855e4ee
commit 79ad7fc
Show file tree

Hide file tree

Showing 49 changed files with 98 additions and 97 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,7 @@
 - Added `include_all_enums` config flag to generate only enums used in supplied operations.
 - Added `operationName` to payload sent by generated client's methods.
 - Fixed base clients to pass `mypy --strict` without installed optional dependencies.
+- Renamed `GraphQlClientInvalidResponseError` to `GraphQLClientInvalidResponseError` (breaking change).
 
 
 ## 0.10.0 (2023-11-15)

diff --git a/EXAMPLE.md b/EXAMPLE.md
@@ -520,7 +520,7 @@ from .exceptions import (
     GraphQLClientGraphQLError,
     GraphQLClientGraphQLMultiError,
     GraphQLClientHttpError,
-    GraphQlClientInvalidResponseError,
+    GraphQLClientInvalidResponseError,
 )
 from .fragments import BasicUser, UserPersonalData
 from .get_users_counter import GetUsersCounter
@@ -547,7 +547,7 @@ __all__ = [
     "GraphQLClientGraphQLError",
     "GraphQLClientGraphQLMultiError",
     "GraphQLClientHttpError",
-    "GraphQlClientInvalidResponseError",
+    "GraphQLClientInvalidResponseError",
     "ListAllUsers",
     "ListAllUsersUsers",
     "ListAllUsersUsersLocation",

diff --git a/ariadne_codegen/client_generators/constants.py b/ariadne_codegen/client_generators/constants.py
@@ -91,7 +91,7 @@
 GRAPHQL_CLIENT_EXCEPTIONS_NAMES = [
     "GraphQLClientError",
     "GraphQLClientHttpError",
-    "GraphQlClientInvalidResponseError",
+    "GraphQLClientInvalidResponseError",
     "GraphQLClientGraphQLError",
     "GraphQLClientGraphQLMultiError",
 ]

diff --git a/ariadne_codegen/client_generators/dependencies/async_base_client.py b/ariadne_codegen/client_generators/dependencies/async_base_client.py
@@ -12,7 +12,7 @@
     GraphQLClientGraphQLMultiError,
     GraphQLClientHttpError,
     GraphQLClientInvalidMessageFormat,
-    GraphQlClientInvalidResponseError,
+    GraphQLClientInvalidResponseError,
 )
 
 try:
@@ -125,10 +125,10 @@ def get_data(self, response: httpx.Response) -> Dict[str, Any]:
         try:
             response_json = response.json()
         except ValueError as exc:
-            raise GraphQlClientInvalidResponseError(response=response) from exc
+            raise GraphQLClientInvalidResponseError(response=response) from exc
 
         if (not isinstance(response_json, dict)) or ("data" not in response_json):
-            raise GraphQlClientInvalidResponseError(response=response)
+            raise GraphQLClientInvalidResponseError(response=response)
 
         data = response_json["data"]
         errors = response_json.get("errors")

diff --git a/ariadne_codegen/client_generators/dependencies/async_base_client_open_telemetry.py b/ariadne_codegen/client_generators/dependencies/async_base_client_open_telemetry.py
@@ -23,7 +23,7 @@
     GraphQLClientGraphQLMultiError,
     GraphQLClientHttpError,
     GraphQLClientInvalidMessageFormat,
-    GraphQlClientInvalidResponseError,
+    GraphQLClientInvalidResponseError,
 )
 
 try:
@@ -164,10 +164,10 @@ def get_data(self, response: httpx.Response) -> Dict[str, Any]:
         try:
             response_json = response.json()
         except ValueError as exc:
-            raise GraphQlClientInvalidResponseError(response=response) from exc
+            raise GraphQLClientInvalidResponseError(response=response) from exc
 
         if (not isinstance(response_json, dict)) or ("data" not in response_json):
-            raise GraphQlClientInvalidResponseError(response=response)
+            raise GraphQLClientInvalidResponseError(response=response)
 
         data = response_json["data"]
         errors = response_json.get("errors")

diff --git a/ariadne_codegen/client_generators/dependencies/base_client.py b/ariadne_codegen/client_generators/dependencies/base_client.py
@@ -9,7 +9,7 @@
 from .exceptions import (
     GraphQLClientGraphQLMultiError,
     GraphQLClientHttpError,
-    GraphQlClientInvalidResponseError,
+    GraphQLClientInvalidResponseError,
 )
 
 Self = TypeVar("Self", bound="BaseClient")
@@ -73,10 +73,10 @@ def get_data(self, response: httpx.Response) -> dict[str, Any]:
         try:
             response_json = response.json()
         except ValueError as exc:
-            raise GraphQlClientInvalidResponseError(response=response) from exc
+            raise GraphQLClientInvalidResponseError(response=response) from exc
 
         if (not isinstance(response_json, dict)) or ("data" not in response_json):
-            raise GraphQlClientInvalidResponseError(response=response)
+            raise GraphQLClientInvalidResponseError(response=response)
 
         data = response_json["data"]
         errors = response_json.get("errors")

diff --git a/ariadne_codegen/client_generators/dependencies/base_client_open_telemetry.py b/ariadne_codegen/client_generators/dependencies/base_client_open_telemetry.py
@@ -9,7 +9,7 @@
 from .exceptions import (
     GraphQLClientGraphQLMultiError,
     GraphQLClientHttpError,
-    GraphQlClientInvalidResponseError,
+    GraphQLClientInvalidResponseError,
 )
 
 try:
@@ -96,10 +96,10 @@ def get_data(self, response: httpx.Response) -> dict[str, Any]:
         try:
             response_json = response.json()
         except ValueError as exc:
-            raise GraphQlClientInvalidResponseError(response=response) from exc
+            raise GraphQLClientInvalidResponseError(response=response) from exc
 
         if (not isinstance(response_json, dict)) or ("data" not in response_json):
-            raise GraphQlClientInvalidResponseError(response=response)
+            raise GraphQLClientInvalidResponseError(response=response)
 
         data = response_json["data"]
         errors = response_json.get("errors")

diff --git a/ariadne_codegen/client_generators/dependencies/exceptions.py b/ariadne_codegen/client_generators/dependencies/exceptions.py
@@ -16,7 +16,7 @@ def __str__(self) -> str:
         return f"HTTP status code: {self.status_code}"
 
 
-class GraphQlClientInvalidResponseError(GraphQLClientError):
+class GraphQLClientInvalidResponseError(GraphQLClientError):
     def __init__(self, response: httpx.Response) -> None:
         self.response = response
 

diff --git a/tests/client_generators/dependencies/test_async_base_client.py b/tests/client_generators/dependencies/test_async_base_client.py
@@ -12,7 +12,7 @@
 from ariadne_codegen.client_generators.dependencies.exceptions import (
     GraphQLClientGraphQLMultiError,
     GraphQLClientHttpError,
-    GraphQlClientInvalidResponseError,
+    GraphQLClientInvalidResponseError,
 )
 
 from ...utils import decode_multipart_request
@@ -513,7 +513,7 @@ def test_get_data_raises_graphql_client_invalid_response_error(
     client = AsyncBaseClient(url="base_url", http_client=mocker.MagicMock())
     response = httpx.Response(status_code=200, content=json.dumps(response_content))
 
-    with pytest.raises(GraphQlClientInvalidResponseError) as exc:
+    with pytest.raises(GraphQLClientInvalidResponseError) as exc:
         client.get_data(response)
         assert exc.response == response
 

diff --git a/tests/client_generators/dependencies/test_async_base_client_open_telemetry.py b/tests/client_generators/dependencies/test_async_base_client_open_telemetry.py
@@ -13,7 +13,7 @@
 from ariadne_codegen.client_generators.dependencies.exceptions import (
     GraphQLClientGraphQLMultiError,
     GraphQLClientHttpError,
-    GraphQlClientInvalidResponseError,
+    GraphQLClientInvalidResponseError,
 )
 
 from ...utils import decode_multipart_request
@@ -530,7 +530,7 @@ def test_get_data_raises_graphql_client_invalid_response_error(
     )
     response = httpx.Response(status_code=200, content=json.dumps(response_content))
 
-    with pytest.raises(GraphQlClientInvalidResponseError) as exc:
+    with pytest.raises(GraphQLClientInvalidResponseError) as exc:
         client.get_data(response)
         assert exc.response == response
 

diff --git a/tests/client_generators/dependencies/test_base_client.py b/tests/client_generators/dependencies/test_base_client.py
@@ -10,7 +10,7 @@
 from ariadne_codegen.client_generators.dependencies.exceptions import (
     GraphQLClientGraphQLMultiError,
     GraphQLClientHttpError,
-    GraphQlClientInvalidResponseError,
+    GraphQLClientInvalidResponseError,
 )
 
 from ...utils import decode_multipart_request
@@ -486,7 +486,7 @@ def test_get_data_raises_graphql_client_invalid_response_error(
     client = BaseClient(url="base_url", http_client=mocker.MagicMock())
     response = httpx.Response(status_code=200, content=json.dumps(response_content))
 
-    with pytest.raises(GraphQlClientInvalidResponseError) as exc:
+    with pytest.raises(GraphQLClientInvalidResponseError) as exc:
         client.get_data(response)
         assert exc.response == response
 

diff --git a/tests/client_generators/dependencies/test_base_client_open_telemetry.py b/tests/client_generators/dependencies/test_base_client_open_telemetry.py
@@ -13,7 +13,7 @@
 from ariadne_codegen.client_generators.dependencies.exceptions import (
     GraphQLClientGraphQLMultiError,
     GraphQLClientHttpError,
-    GraphQlClientInvalidResponseError,
+    GraphQLClientInvalidResponseError,
 )
 
 from ...utils import decode_multipart_request
@@ -499,7 +499,7 @@ def test_get_data_raises_graphql_client_invalid_response_error(
     client = BaseClientOpenTelemetry(url="base_url", http_client=mocker.MagicMock())
     response = httpx.Response(status_code=200, content=json.dumps(response_content))
 
-    with pytest.raises(GraphQlClientInvalidResponseError) as exc:
+    with pytest.raises(GraphQLClientInvalidResponseError) as exc:
         client.get_data(response)
         assert exc.response == response
 

diff --git a/tests/client_generators/package_generator/test_generated_files.py b/tests/client_generators/package_generator/test_generated_files.py
@@ -106,7 +106,7 @@ def test_generate_creates_files_with_correct_imports(
                 "GraphQLClientGraphQLError",
                 "GraphQLClientGraphQLMultiError",
                 "GraphQLClientHttpError",
-                "GraphQlClientInvalidResponseError",
+                "GraphQLClientInvalidResponseError",
                 "Upload",
             ]
         """

diff --git a/tests/main/clients/custom_config_file/expected_client/__init__.py b/tests/main/clients/custom_config_file/expected_client/__init__.py
@@ -6,7 +6,7 @@
     GraphQLClientGraphQLError,
     GraphQLClientGraphQLMultiError,
     GraphQLClientHttpError,
-    GraphQlClientInvalidResponseError,
+    GraphQLClientInvalidResponseError,
 )
 from .test import Test
 
@@ -18,7 +18,7 @@
     "GraphQLClientGraphQLError",
     "GraphQLClientGraphQLMultiError",
     "GraphQLClientHttpError",
-    "GraphQlClientInvalidResponseError",
+    "GraphQLClientInvalidResponseError",
     "Test",
     "Upload",
 ]
diff --git a/tests/main/clients/custom_config_file/expected_client/async_base_client.py b/tests/main/clients/custom_config_file/expected_client/async_base_client.py
@@ -12,7 +12,7 @@
     GraphQLClientGraphQLMultiError,
     GraphQLClientHttpError,
     GraphQLClientInvalidMessageFormat,
-    GraphQlClientInvalidResponseError,
+    GraphQLClientInvalidResponseError,
 )
 
 try:
@@ -125,10 +125,10 @@ def get_data(self, response: httpx.Response) -> Dict[str, Any]:
         try:
             response_json = response.json()
         except ValueError as exc:
-            raise GraphQlClientInvalidResponseError(response=response) from exc
+            raise GraphQLClientInvalidResponseError(response=response) from exc
 
         if (not isinstance(response_json, dict)) or ("data" not in response_json):
-            raise GraphQlClientInvalidResponseError(response=response)
+            raise GraphQLClientInvalidResponseError(response=response)
 
         data = response_json["data"]
         errors = response_json.get("errors")

diff --git a/tests/main/clients/custom_config_file/expected_client/exceptions.py b/tests/main/clients/custom_config_file/expected_client/exceptions.py
@@ -16,7 +16,7 @@ def __str__(self) -> str:
         return f"HTTP status code: {self.status_code}"
 
 
-class GraphQlClientInvalidResponseError(GraphQLClientError):
+class GraphQLClientInvalidResponseError(GraphQLClientError):
     def __init__(self, response: httpx.Response) -> None:
         self.response = response
 

diff --git a/tests/main/clients/custom_files_names/expected_client/__init__.py b/tests/main/clients/custom_files_names/expected_client/__init__.py
@@ -8,7 +8,7 @@
     GraphQLClientGraphQLError,
     GraphQLClientGraphQLMultiError,
     GraphQLClientHttpError,
-    GraphQlClientInvalidResponseError,
+    GraphQLClientInvalidResponseError,
 )
 from .get_query_a import GetQueryA, GetQueryAQueryA
 
@@ -22,7 +22,7 @@
     "GraphQLClientGraphQLError",
     "GraphQLClientGraphQLMultiError",
     "GraphQLClientHttpError",
-    "GraphQlClientInvalidResponseError",
+    "GraphQLClientInvalidResponseError",
     "Upload",
     "enumA",
     "inputA",

diff --git a/tests/main/clients/custom_files_names/expected_client/async_base_client.py b/tests/main/clients/custom_files_names/expected_client/async_base_client.py
@@ -12,7 +12,7 @@
     GraphQLClientGraphQLMultiError,
     GraphQLClientHttpError,
     GraphQLClientInvalidMessageFormat,
-    GraphQlClientInvalidResponseError,
+    GraphQLClientInvalidResponseError,
 )
 
 try:
@@ -125,10 +125,10 @@ def get_data(self, response: httpx.Response) -> Dict[str, Any]:
         try:
             response_json = response.json()
         except ValueError as exc:
-            raise GraphQlClientInvalidResponseError(response=response) from exc
+            raise GraphQLClientInvalidResponseError(response=response) from exc
 
         if (not isinstance(response_json, dict)) or ("data" not in response_json):
-            raise GraphQlClientInvalidResponseError(response=response)
+            raise GraphQLClientInvalidResponseError(response=response)
 
         data = response_json["data"]
         errors = response_json.get("errors")

diff --git a/tests/main/clients/custom_files_names/expected_client/exceptions.py b/tests/main/clients/custom_files_names/expected_client/exceptions.py
@@ -16,7 +16,7 @@ def __str__(self) -> str:
         return f"HTTP status code: {self.status_code}"
 
 
-class GraphQlClientInvalidResponseError(GraphQLClientError):
+class GraphQLClientInvalidResponseError(GraphQLClientError):
     def __init__(self, response: httpx.Response) -> None:
         self.response = response
 

diff --git a/tests/main/clients/custom_scalars/expected_client/__init__.py b/tests/main/clients/custom_scalars/expected_client/__init__.py
@@ -6,7 +6,7 @@
     GraphQLClientGraphQLError,
     GraphQLClientGraphQLMultiError,
     GraphQLClientHttpError,
-    GraphQlClientInvalidResponseError,
+    GraphQLClientInvalidResponseError,
 )
 from .get_a import GetA, GetATestQuery
 from .input_types import TestInput
@@ -21,7 +21,7 @@
     "GraphQLClientGraphQLError",
     "GraphQLClientGraphQLMultiError",
     "GraphQLClientHttpError",
-    "GraphQlClientInvalidResponseError",
+    "GraphQLClientInvalidResponseError",
     "TestInput",
     "Upload",
 ]
diff --git a/tests/main/clients/custom_scalars/expected_client/async_base_client.py b/tests/main/clients/custom_scalars/expected_client/async_base_client.py
@@ -12,7 +12,7 @@
     GraphQLClientGraphQLMultiError,
     GraphQLClientHttpError,
     GraphQLClientInvalidMessageFormat,
-    GraphQlClientInvalidResponseError,
+    GraphQLClientInvalidResponseError,
 )
 
 try:
@@ -125,10 +125,10 @@ def get_data(self, response: httpx.Response) -> Dict[str, Any]:
         try:
             response_json = response.json()
         except ValueError as exc:
-            raise GraphQlClientInvalidResponseError(response=response) from exc
+            raise GraphQLClientInvalidResponseError(response=response) from exc
 
         if (not isinstance(response_json, dict)) or ("data" not in response_json):
-            raise GraphQlClientInvalidResponseError(response=response)
+            raise GraphQLClientInvalidResponseError(response=response)
 
         data = response_json["data"]
         errors = response_json.get("errors")

diff --git a/tests/main/clients/custom_scalars/expected_client/exceptions.py b/tests/main/clients/custom_scalars/expected_client/exceptions.py
@@ -16,7 +16,7 @@ def __str__(self) -> str:
         return f"HTTP status code: {self.status_code}"
 
 
-class GraphQlClientInvalidResponseError(GraphQLClientError):
+class GraphQLClientInvalidResponseError(GraphQLClientError):
     def __init__(self, response: httpx.Response) -> None:
         self.response = response
 

diff --git a/tests/main/clients/example/expected_client/__init__.py b/tests/main/clients/example/expected_client/__init__.py
@@ -8,7 +8,7 @@
     GraphQLClientGraphQLError,
     GraphQLClientGraphQLMultiError,
     GraphQLClientHttpError,
-    GraphQlClientInvalidResponseError,
+    GraphQLClientInvalidResponseError,
 )
 from .fragments import BasicUser, UserPersonalData
 from .get_users_counter import GetUsersCounter
@@ -35,7 +35,7 @@
     "GraphQLClientGraphQLError",
     "GraphQLClientGraphQLMultiError",
     "GraphQLClientHttpError",
-    "GraphQlClientInvalidResponseError",
+    "GraphQLClientInvalidResponseError",
     "ListAllUsers",
     "ListAllUsersUsers",
     "ListAllUsersUsersLocation",

diff --git a/tests/main/clients/example/expected_client/async_base_client.py b/tests/main/clients/example/expected_client/async_base_client.py
@@ -12,7 +12,7 @@
     GraphQLClientGraphQLMultiError,
     GraphQLClientHttpError,
     GraphQLClientInvalidMessageFormat,
-    GraphQlClientInvalidResponseError,
+    GraphQLClientInvalidResponseError,
 )
 
 try:
@@ -125,10 +125,10 @@ def get_data(self, response: httpx.Response) -> Dict[str, Any]:
         try:
             response_json = response.json()
         except ValueError as exc:
-            raise GraphQlClientInvalidResponseError(response=response) from exc
+            raise GraphQLClientInvalidResponseError(response=response) from exc
 
         if (not isinstance(response_json, dict)) or ("data" not in response_json):
-            raise GraphQlClientInvalidResponseError(response=response)
+            raise GraphQLClientInvalidResponseError(response=response)
 
         data = response_json["data"]
         errors = response_json.get("errors")