Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#132 Add Clang-Format and Clang-Tidy checks #137

Merged
merged 5 commits into from
Jul 31, 2024

Conversation

vityaman
Copy link
Contributor

@vityaman vityaman commented Jul 29, 2024

  • Added .clang-format config file
  • Added .clang-tidy config file
  • Formatted code to satisfy format checks
  • Edited code to satisfy lint checks
  • Running clang-tidy only on source directory (not tests), because it works very slowly
  • Fixed ccache key

If you have serious concerns about clang-tidy fixes or is it difficult to read the code, I can close this MR and then open one with only Clang-Format changes and then another one with only Clang-Tidy changes.

@vityaman vityaman force-pushed the 132-port-cpp-format branch from 589f084 to 2358ecf Compare July 29, 2024 08:45
@vityaman vityaman marked this pull request as ready for review July 29, 2024 08:50
Copy link
Owner

@mike-lischke mike-lischke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objections, except the short line length. A length of 80 characters is IMO too small these days. Better is 100 or 120, but as always with formatting, this is a personal preference. Good to see tab indentation has been replaced with space indentation.

@vityaman
Copy link
Contributor Author

  • Raised line width up to 100
  • Changed formatting rules a little
  • Did tiny-tiny test refactoring

@mike-lischke mike-lischke merged commit 5e06d07 into mike-lischke:main Jul 31, 2024
6 checks passed
@mike-lischke
Copy link
Owner

Thanks!

@vityaman vityaman deleted the 132-port-cpp-format branch July 31, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants