#132 Add Clang-Tidy check

Signed-off-by: vityaman <[email protected]>

.github/workflows/cmake.yml

@@ -17,26 +17,32 @@ jobs:
     strategy:
       matrix:
         cmake_build_type: [Asan, Release]
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
-      - uses: actions/checkout@v3
+      - name: Checkout
+        uses: actions/checkout@v3
+
       - name: Install dependencies
         run: |
+          wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | sudo apt-key add -
+          sudo add-apt-repository "deb http://apt.llvm.org/noble/ llvm-toolchain-noble-18 main"
           sudo apt update
           sudo apt install build-essential
+          sudo apt install clang-format-18 clang-tidy-18
+
       - name: Setup ccache
         uses: hendrikmuhs/[email protected]
         with:
           create-symlink: true
-          key: ${{ github.job }}-${{ matrix.os }}
+          key: ${{ github.job }}-${{ matrix.cmake_build_type }}
+
       - name: Clang-Format
         working-directory: ${{github.workspace}}/ports/cpp
         run: |
-          ( \
-            find source test -iname '*.hpp' -o -iname '*.cpp' \
-            | xargs clang-format -Werror --dry-run \
-              --fallback-style=Google --verbose \
-          )
+          find source test -iname '*.hpp' -o -iname '*.cpp' \
+          | xargs clang-format-18 -Werror --dry-run \
+              --fallback-style=Google --verbose
+
       - name: Configure
         working-directory: ${{github.workspace}}/ports/cpp
         run: |
@@ -46,11 +52,20 @@ jobs:
             -DANTLR4C3_DEVELOPER=ON \
             -DCMAKE_BUILD_TYPE=${{ matrix.cmake_build_type }} \
             ..
+
       - name: Build
         working-directory: ${{github.workspace}}/ports/cpp/build
         run: make
+
       - name: Unit Test
         working-directory: ${{github.workspace}}/ports/cpp/build/test
         run: |
           ctest 
           cat Testing/Temporary/LastTest.log
+
+      - name: Clang-Tidy on sources
+        if: matrix.cmake_build_type == 'Release'
+        working-directory: ${{github.workspace}}/ports/cpp
+        run: |
+          find source -iname '*.hpp' -o -iname '*.cpp' \
+          | xargs clang-tidy-18 -p build/compile_commands.json

ports/cpp/.clang-format

@@ -2,6 +2,7 @@
 Language: Cpp
 BasedOnStyle: Google
 
+ColumnLimit: 80
 AccessModifierOffset: -2
 
 AllowShortFunctionsOnASingleLine: None

ports/cpp/.clang-tidy

@@ -0,0 +1,22 @@
+---
+Checks: '-*,
+  bugprone-*,
+  cert-*,
+  concurrency-*,
+  cppcoreguidelines-*,
+  google-*,
+  hicpp-*,
+  misc-*,
+  -misc-no-recursion,
+  modernize-*,
+  -modernize-use-trailing-return-type,
+  performance-*,
+  readability-*'
+WarningsAsErrors: '*'
+HeaderFileExtensions:
+  - hpp
+ImplementationFileExtensions:
+  - cpp
+HeaderFilterRegex: ''
+FormatStyle: '.clang-format'
+SystemHeaders: false