Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3937 - Parse the current Python version to the Dockerfile in pf build flow #3939

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

adam-lagoda
Copy link

@adam-lagoda adam-lagoda commented Jan 23, 2025

Description

Issue: #3937
This PR includes a modification where the python version in the conda environment in the deployed docker image is parsed from the environment that calls the build command.
This way, if the user writes his flows using python 3.12 syntax, breaking changes (linting for example) will not occur after deployment.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • I confirm that all new dependencies are compatible with the MIT license.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@adam-lagoda adam-lagoda requested a review from a team as a code owner January 23, 2025 12:25
@adam-lagoda adam-lagoda changed the title 3152 - Parse the current Python version to the Dockerfile in pf build flow 3937 - Parse the current Python version to the Dockerfile in pf build flow Jan 23, 2025
@adam-lagoda
Copy link
Author

@microsoft-github-policy-service agree

@ebotiab
Copy link

ebotiab commented Jan 26, 2025

This would be a nice feature, change the python version is needed in the Azure AI foundry promptflow as well

@adam-lagoda
Copy link
Author

This would be a nice feature, change the python version is needed in the Azure AI foundry promptflow as well

Could you please elaborate what you mean?

@ebotiab
Copy link

ebotiab commented Jan 26, 2025

This would be a nice feature, change the python version is needed in the Azure AI foundry promptflow as well

Could you please elaborate what you mean?

The default python version in Azure AI foundry is lower than 3.10 and they not provide documentation on how to change it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants