Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Python 3.10 o3 3.11 #3152

Closed
FriederikeBrezing opened this issue May 8, 2024 · 9 comments · Fixed by #3187
Closed

Upgrade to Python 3.10 o3 3.11 #3152

FriederikeBrezing opened this issue May 8, 2024 · 9 comments · Fixed by #3187
Assignees
Labels
enhancement New feature or request

Comments

@FriederikeBrezing
Copy link

We would like to upgrade our code base to Python 3.10 or 3.11.
Some packages that we would like to use, like PyRit, require Python >= 3.10.
Promptflow still recommends using 3.9.

Describe the solution you'd like
Promptflow should fully support Python 3.10 or higher

@FriederikeBrezing FriederikeBrezing added the enhancement New feature or request label May 8, 2024
@D-W- D-W- self-assigned this May 9, 2024
@D-W-
Copy link
Contributor

D-W- commented May 9, 2024

Hi @FriederikeBrezing , we publicly support python 3.10 and 3.11. Check here for current supported versions:
image

@FriederikeBrezing
Copy link
Author

Hi, I had seen that but it also says that python 3.9 is recommended.
What is the reason for that? Will it affect the performance if other versions of python are used?

Screenshot 2024-05-09 at 09 47 28

@D-W-
Copy link
Contributor

D-W- commented May 10, 2024

This is a comment written before we supported Python 3.9. I will delete it to avoid confusion.

@D-W- D-W- linked a pull request May 10, 2024 that will close this issue
7 tasks
@amichel
Copy link

amichel commented Oct 8, 2024

The Docker file in the dev container is still based on the python:3.9 image. Can it be upgraded as well?

@adam-lagoda
Copy link

@amichel same goes for the default version when building using
pf flow build --source ./flows/standard --output dist --format docker

And the output Dockerfile contains
RUN conda create -n promptflow-serve python=3.9.16 [..] by default
Can this be altered?
I would kindly ask @wangchao1230 to reopen

@HakjunMIN
Copy link

@wangchao1230 Hey. Please open this issue again

pf flow build --source ./flows/standard --output dist --format docker

And the output Dockerfile contains
RUN conda create -n promptflow-serve python=3.9.16 [..] by default

Please make its version configurable !!!

@adam-lagoda
Copy link

python version in the deployed image is fixed in src/promptflow-devkit/promptflow/_sdk/data/docker/Dockerfile.jinja2
Would be great to make this configurable, or at least parsable from the python version from the active environment that is used for the build.

@adam-lagoda
Copy link

I have added a separate issue to address this feature request
#3937

@adam-lagoda
Copy link

I also made a PR that solves the problem
#3939

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants