Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fundamental] Exclude examples/flows/integrations from workflows #1176

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

zhengfeiwang
Copy link
Contributor

@zhengfeiwang zhengfeiwang commented Nov 17, 2023

Description

examples/flows/integrations folder tagrtes to be 3P contributed examples folder, we shouldn't apply workflow covering this.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@zhengfeiwang zhengfeiwang requested a review from a team as a code owner November 17, 2023 05:51
Copy link

Executor Unit Test Result zhengfei/example/no-ci4integration

564 tests   564 ✔️  49s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit 20729d6.

Copy link

promptflow SDK CLI Azure Unit Test Result zhengfei/example/no-ci4integration

  2 files    2 suites   39s ⏱️
32 tests 30 ✔️ 2 💤 0
64 runs  60 ✔️ 4 💤 0

Results for commit 20729d6.

Copy link

promptflow SDK CLI Azure E2E Test Result zhengfei/example/no-ci4integration

    2 files    2 suites   1m 30s ⏱️
  59 tests 40 ✔️ 19 💤 0
118 runs  80 ✔️ 38 💤 0

Results for commit 20729d6.

Copy link

SDK PFS E2E Test Result zhengfei/example/no-ci4integration

  2 files    2 suites   45s ⏱️
  9 tests   9 ✔️ 0 💤 0
18 runs  18 ✔️ 0 💤 0

Results for commit 20729d6.

Copy link

Executor E2E Test Result zhengfei/example/no-ci4integration

138 tests   134 ✔️  2m 37s ⏱️
    1 suites      4 💤
    1 files        0

Results for commit 20729d6.

Copy link

SDK CLI Test Result zhengfei/example/no-ci4integration

352 tests   343 ✔️  12m 6s ⏱️
    1 suites      9 💤
    1 files        0

Results for commit 20729d6.

Copy link

SDK CLI Global Config Test Result zhengfei/example/no-ci4integration

2 tests   2 ✔️  48s ⏱️
1 suites  0 💤
1 files    0

Results for commit 20729d6.

@zhengfeiwang zhengfeiwang merged commit 65072bf into main Nov 17, 2023
45 of 46 checks passed
@zhengfeiwang zhengfeiwang deleted the zhengfei/example/no-ci4integration branch November 17, 2023 06:58
zhengfeiwang added a commit that referenced this pull request Nov 17, 2023
# Description

Fix typo (missing s) introduced in #1176 

# All Promptflow Contribution checklist:
- [x] **The pull request does not introduce [breaking changes].**
- [ ] **CHANGELOG is updated for new features, bug fixes or other
significant changes.**
- [x] **I have read the [contribution guidelines](../CONTRIBUTING.md).**
- [ ] **Create an issue and link to the pull request to get dedicated
review from promptflow team. Learn more: [suggested
workflow](../CONTRIBUTING.md#suggested-workflow).**

## General Guidelines and Best Practices
- [x] Title of the pull request is clear and informative.
- [x] There are a small number of commits, each of which have an
informative message. This means that previously merged commits do not
appear in the history of the PR. For more information on cleaning up the
commits in your PR, [see this
page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### Testing Guidelines
- [x] Pull request includes test coverage for the included changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants