Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[example][fundamental] Fix typo for exclude path #1178

Merged
merged 1 commit into from
Nov 17, 2023
Merged

[example][fundamental] Fix typo for exclude path #1178

merged 1 commit into from
Nov 17, 2023

Conversation

zhengfeiwang
Copy link
Contributor

@zhengfeiwang zhengfeiwang commented Nov 17, 2023 •
edited
Loading

Description

Fix typo (missing s) introduced in #1176

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@zhengfeiwang zhengfeiwang requested a review from a team as a code owner November 17, 2023 07:07
@github-actions GitHub Actions
Copy link

SDK CLI Global Config Test Result zhengfei/bugfix/fix-typo

2 tests   2 ✔️  57s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 1a2e6e2.

@github-actions GitHub Actions
Copy link

Executor Unit Test Result zhengfei/bugfix/fix-typo

564 tests   564 ✔️  48s ⏱️
    1 suites      0 💤
    1 files        0 ❌

Results for commit 1a2e6e2.

@zhengfeiwang zhengfeiwang merged commit 86cfe5a into main Nov 17, 2023
@zhengfeiwang zhengfeiwang deleted the zhengfei/bugfix/fix-typo branch November 17, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazygao crazygao crazygao approved these changes

@wangchao1230 wangchao1230 wangchao1230 approved these changes

Assignees
No one assigned
Labels
fundamental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhengfeiwang @crazygao @wangchao1230