Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NPKIT] Adding the NPKIT support for kernel allreduce7 in mscclpp-nccl #399

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

PedramAlizadeh
Copy link
Contributor

No description provided.

@Binyang2014 Binyang2014 requested a review from yzygitzh December 3, 2024 23:51
Copy link
Member

@yzygitzh yzygitzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. We need add test for this change in the future.

CMakeLists.txt Outdated Show resolved Hide resolved
apps/nccl/CMakeLists.txt Outdated Show resolved Hide resolved
include/mscclpp/npkit/npkit_event.hpp Show resolved Hide resolved
apps/nccl/CMakeLists.txt Outdated Show resolved Hide resolved
@PedramAlizadeh
Copy link
Contributor Author

@microsoft-github-policy-service agree company="AMD"

Copy link
Contributor

@chhwang chhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chhwang chhwang changed the title [NPKIT] Adding the NPKIT support for kernel allreduce7 in mscclpp [NPKIT] Adding the NPKIT support for kernel allreduce7 in mscclpp-nccl Jan 3, 2025
@chhwang chhwang enabled auto-merge (squash) January 3, 2025 20:37
@chhwang chhwang merged commit 97eaca2 into microsoft:main Jan 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants