Skip to content

Commit

Permalink
modifications to keep code format consistent
Browse files Browse the repository at this point in the history
  • Loading branch information
PedramAlizadeh committed Jan 2, 2025
1 parent 501c02d commit cdb1a25
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 9 deletions.
7 changes: 4 additions & 3 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# Copyright (c) Microsoft Corporation.
# Modifications Copyright (c) Advanced Micro Devices, Inc. All rights reserved.
# Licensed under the MIT license.

set(MSCCLPP_MAJOR "0")
Expand All @@ -20,7 +21,7 @@ option(BUILD_PYTHON_BINDINGS "Build Python bindings" ON)
option(BUILD_APPS_NCCL "Build NCCL interfaces" ON)
option(USE_CUDA "Use NVIDIA/CUDA." OFF)
option(USE_ROCM "Use AMD/ROCm." OFF)
option(${NPKIT_FLAGS} "Enable NPKIT" OFF)
option(MSCCLPP_NPKIT_FLAGS "Enable NPKIT" OFF)
option(BYPASS_GPU_CHECK "Bypass GPU check." OFF)

if(BYPASS_GPU_CHECK)
Expand Down Expand Up @@ -124,8 +125,8 @@ endif()
if(ENABLE_TRACE)
target_compile_definitions(mscclpp_obj PRIVATE ENABLE_TRACE)
endif()
if(NPKIT_FLAGS)
target_compile_definitions(mscclpp_obj PRIVATE ${NPKIT_FLAGS})
if(MSCCLPP_NPKIT_FLAGS)
target_compile_definitions(mscclpp_obj PRIVATE ${MSCCLPP_NPKIT_FLAGS})
endif()

# libmscclpp
Expand Down
5 changes: 3 additions & 2 deletions apps/nccl/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# Copyright (c) Microsoft Corporation.
# Modifications Copyright (c) Advanced Micro Devices, Inc. All rights reserved.
# Licensed under the MIT license.

file(GLOB_RECURSE SOURCES CONFIGURE_DEPENDS src/*)
Expand All @@ -19,8 +20,8 @@ if(USE_CUDA)
elseif(USE_ROCM)
target_compile_definitions(mscclpp_nccl_obj PRIVATE USE_ROCM)
endif()
if(NPKIT_FLAGS)
target_compile_definitions(mscclpp_nccl_obj PRIVATE ${NPKIT_FLAGS})
if(MSCCLPP_NPKIT_FLAGS)
target_compile_definitions(mscclpp_nccl_obj PRIVATE ${MSCCLPP_NPKIT_FLAGS})
endif()
add_library(mscclpp_nccl SHARED)
target_link_libraries(mscclpp_nccl PUBLIC mscclpp_obj mscclpp_nccl_obj)
Expand Down
1 change: 1 addition & 0 deletions apps/nccl/src/allreduce.hpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// Copyright (c) Microsoft Corporation.
// Modifications Copyright (c) Advanced Micro Devices, Inc. All rights reserved.
// Licensed under the MIT license.

#ifndef ALLREDUCE_HPP_
Expand Down
1 change: 1 addition & 0 deletions apps/nccl/src/nccl.cu
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// Copyright (c) Microsoft Corporation.
// Modifications Copyright (c) Advanced Micro Devices, Inc. All rights reserved.
// Licensed under the MIT license.

#include <algorithm>
Expand Down
9 changes: 5 additions & 4 deletions include/mscclpp/npkit/npkit_event.hpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// Copyright (c) Microsoft Corporation.
// Modifications Copyright (c) Advanced Micro Devices, Inc. All rights reserved.
// Licensed under the MIT license.

#ifndef NPKIT_EVENT_H_
Expand All @@ -12,10 +13,10 @@
#define NPKIT_EVENT_EXECUTOR_INIT_ENTRY 0x3
#define NPKIT_EVENT_EXECUTOR_INIT_EXIT 0x4

#define NPKIT_EVENT_EXECUTOR_OP_BASE_ENTRY 0x5
#define NPKIT_EVENT_EXECUTOR_OP_BASE_EXIT 0x17
#define NPKIT_EVENT_KERNEL_ALLREDUCE_ENTRY 0x5
#define NPKIT_EVENT_KERNEL_ALLREDUCE_EXIT 0x6

#define NPKIT_EVENT_KERNEL_ALLREDUCE_ENTRY 0x6
#define NPKIT_EVENT_KERNEL_ALLREDUCE_EXIT 0x7
#define NPKIT_EVENT_EXECUTOR_OP_BASE_ENTRY 0x7
#define NPKIT_EVENT_EXECUTOR_OP_BASE_EXIT 0x19

#endif

0 comments on commit cdb1a25

Please sign in to comment.