feat: ability to retrieve agents session, turn, step by ids #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
yanxi0830
commented
Feb 26, 2025
| @@ -21,6 +21,7 @@ | |||
| class AgentSessionInfo(BaseModel): | |||
| session_id: str | |||
| session_name: str | |||
| # TODO: is this used anywhere? | |||
There was a problem hiding this comment.
Maybe remove this vector_db_id within the Agent session? Should be possible for an agent session to have access to multiple vector_db_ids?
There was a problem hiding this comment.
Seems arbitrary to have a single vector db id here. Maybe remove in another PR?
yanxi0830
requested review from
ashwinb,
hardikjshah,
dltn,
raghotham,
dineshyv,
vladimirivic,
sixianyi0721,
ehhuang and
terrytangyuan
as code owners
raghotham
approved these changes
Feb 27, 2025
yanxi0830
added a commit
that referenced
this pull request
Feb 27, 2025
# What does this PR do? - It is not being used anywhere and doesn't make sense to have 1 single vector_db_id in an agent session. No top level API change. - See #1286 (comment) [//]: # (If resolving an issue, uncomment and update the line below) [//]: # (Closes #[issue-number]) ## Test Plan - See #1286 (comment) [//]: # (## Documentation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix up rotten implementation for retrieving agent's Session, Turn, Step with actual working implementation.
Update
getting_startednotebook with retrieving by agent session_id. https://github.com/meta-llama/llama-stack/blob/export_agent_dataset/docs/getting_started.ipynbTest Plan
Test with script: https://gist.github.com/yanxi0830/657cecee8f1f0e39d322963d9c0f598e