Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove vector_db_id from AgentSessionInfo #1296

Merged
merged 1 commit into from
Feb 27, 2025
Merged

chore: remove vector_db_id from AgentSessionInfo #1296

merged 1 commit into from
Feb 27, 2025

Conversation

yanxi0830
Copy link
Contributor

@yanxi0830 yanxi0830 commented Feb 27, 2025 •
edited
Loading

What does this PR do?

Test Plan

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 27, 2025
@yanxi0830 yanxi0830 marked this pull request as ready for review February 27, 2025 17:53
@yanxi0830 yanxi0830 merged commit 200ef29 into main Feb 27, 2025
4 checks passed
@yanxi0830 yanxi0830 deleted the remove_agent_session_info branch February 27, 2025 18:13
yanxi0830 added a commit that referenced this pull request Feb 27, 2025
@yanxi0830
Revert "chore: remove vector_db_id from AgentSessionInfo (#1296)"
90c66c2 
This reverts commit 200ef29.
@yanxi0830 yanxi0830 mentioned this pull request Feb 27, 2025
Merged
yanxi0830 added a commit that referenced this pull request Feb 27, 2025
@yanxi0830
fix: Revert "chore: remove vector_db_id from AgentSessionInfo" (#1299)
564f0e5 
Reverts #1296

This change breaks test: `session_info.vector_db_id` is actually used
```
pytest -v tests/client-sdk/agents/test_agents.py::test_rag_and_code_agent --inference-model meta-llama/Llama-3.1-8B-Instruct
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwinb ashwinb ashwinb approved these changes

@hardikjshah hardikjshah Awaiting requested review from hardikjshah hardikjshah is a code owner

@dltn dltn Awaiting requested review from dltn dltn is a code owner

@raghotham raghotham Awaiting requested review from raghotham raghotham is a code owner

@dineshyv dineshyv Awaiting requested review from dineshyv dineshyv is a code owner

@vladimirivic vladimirivic Awaiting requested review from vladimirivic vladimirivic is a code owner

@sixianyi0721 sixianyi0721 Awaiting requested review from sixianyi0721 sixianyi0721 is a code owner

@ehhuang ehhuang Awaiting requested review from ehhuang ehhuang is a code owner

@terrytangyuan terrytangyuan Awaiting requested review from terrytangyuan terrytangyuan is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yanxi0830 @ashwinb @facebook-github-bot