-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(css): add star.gif #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What size would you prefer? We can have multiple sizes for multiple scenarios. |
8px based sizes are usually pretty common: 16, 24, 32. Something like that :) |
Created 16x16, 32x32, and 256x256 sized normal and inverted versions. Also added some more images from the content repo that have been duplicated 3-4 times. We will update content later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Carrying this one over since Vadim is on PTO. Looks like review comments addressed, everything else looks good to me. Thank you!
I've used existing images from the shared-assets in the PR. The
star.gif
would be an excellent addition to reusable images for the demos.