Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use images from shared-assets #35608

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Use images from shared-assets #35608

merged 2 commits into from
Aug 27, 2024

Conversation

OnkarRuikar
Copy link
Contributor

Bigger and frequently used images have been moved to shared assets. The PR deletes them from content and updates URLs to use shared assets location.

@OnkarRuikar OnkarRuikar requested review from a team as code owners August 27, 2024 12:30
@OnkarRuikar OnkarRuikar requested review from Elchi3 and estelle and removed request for a team August 27, 2024 12:30
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Aug 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 27, 2024 •
edited
Loading

Preview URLs (11 pages)
Flaws (3)

Note! 9 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/XRInputSource
Title: XRInputSource
Flaw count: 1

  • images:
    • External image URL

URL: /en-US/docs/Web/API/XRInputSource/targetRayMode
Title: XRInputSource: targetRayMode property
Flaw count: 2

  • images:
    • External image URL
  • broken_links:
    • Can't resolve /en-US/docs/Web/API/WebXR_Device_API/Gamepads

(comment last updated: 2024-08-27 12:50:34)

estelle
estelle approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@estelle estelle merged commit c0f1aec into mdn:main Aug 27, 2024
8 checks passed
@OnkarRuikar OnkarRuikar deleted the content_images branch August 28, 2024 01:14
@yin1999 yin1999 mentioned this pull request Aug 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

@Elchi3 Elchi3 Awaiting requested review from Elchi3 Elchi3 is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OnkarRuikar @estelle