Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration of Secure Payment Confirmation #30439
Integration of Secure Payment Confirmation #30439
Changes from 78 commits
0a98ba2
2e05011
a7671ae
3acc967
115f1f0
7aba4ea
24a5acd
1322797
d538353
483d2e2
6f23171
088f6c6
4c403d9
394a5cb
129f338
be02eaa
197b872
ffbacda
1bba266
bcba29e
70fabcd
ee18f50
4d55c6d
19edea5
dd81411
5aeee65
5de3613
0c40df9
f282621
5d2e547
448fc56
63c0095
b9b0acb
3bf1191
744ad07
e3e6638
2d16ce7
25e6037
ad36c34
abc77cb
c001554
df2005b
0de9e98
f778ff5
99ce4ce
f72f520
bfc6abb
bfb457f
bcfdef1
ce94698
f5a49b5
328f8b4
89365f7
e832019
137a7ac
cbc98ca
728eaae
11b5661
1d4f417
b08def8
c88f437
e4db12d
3389cdd
8008a79
e0b41c9
edfd7e4
96e9afa
491416c
12383f3
28ef9e7
592c398
8dad8d4
085386a
f478323
57b2780
e3d7c2c
d59de9e
b3c43e1
525072c
f58352a
e977c80
ecd21f6
1f6afe8
6cd61f6
d87b455
9ef0483
4c6a874
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[markdownlint] reported by reviewdog 🐶
MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: ---]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better here to duplicate the content than to link, if it's all correct in this context:
(also we should probably have "challenge" in the MDN glossary but that can wait for another day)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand this description and could not find a useful description of it. But maybe we can't do better here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is optional, but I'm not sure what the default is here.