Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome/Deno/Node/Safari started rejecting ReadableStream*Reader.releaseLock() with pending read requests #25516

Merged
merged 8 commits into from
Jan 8, 2025
Merged

Chrome/Deno/Node/Safari started rejecting ReadableStream*Reader.releaseLock() with pending read requests #25516

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
16d3b25
Update reject_pending_read_request
MattiasBuelens Dec 27, 2024
dfca1f4
Fix format
MattiasBuelens Dec 27, 2024
d78a916
Add Node.js 18.9.0 to browsers
MattiasBuelens Dec 27, 2024
8ea9b2d
Merge reject_pending_read_request into releaseLock
MattiasBuelens Dec 28, 2024
d3b6439
Use version_removed
MattiasBuelens Dec 28, 2024
7df65c9
Revert "Use version_removed"
MattiasBuelens Jan 2, 2025
52cb87d
Revert "Merge reject_pending_read_request into releaseLock"
MattiasBuelens Jan 2, 2025
c8d4742
Address review comments
MattiasBuelens Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 33 additions & 49 deletions api/ReadableStreamBYOBReader.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,13 +266,29 @@
"mdn_url": "https://developer.mozilla.org/docs/Web/API/ReadableStreamBYOBReader/releaseLock",
"spec_url": "https://streams.spec.whatwg.org/#ref-for-byob-reader-release-lock②",
"support": {
"chrome": {
"version_added": "89"
},
"chrome": [
{
"version_added": "105"
},
{
"version_added": "89",
"version_removed": "105",
"partial_implementation": true,
"notes": "The `releaseLock()` method would throw if there are pending read requests (rather than pending read requests being rejected)."
}
],
"chrome_android": "mirror",
"deno": {
"version_added": "1.16"
},
"deno": [
{
"version_added": "1.18"
},
{
"version_added": "1.16",
"version_removed": "1.18",
"partial_implementation": true,
"notes": "The `releaseLock()` method would throw if there are pending read requests (rather than pending read requests being rejected)."
}
],
"edge": "mirror",
"firefox": {
"version_added": "102"
Expand All @@ -281,9 +297,17 @@
"ie": {
"version_added": false
},
"nodejs": {
"version_added": "16.5.0"
},
"nodejs": [
{
"version_added": "18.9.0"
},
{
"version_added": "16.5.0",
"version_removed": "18.9.0",
"partial_implementation": true,
"notes": "The `releaseLock()` method would throw if there are pending read requests (rather than pending read requests being rejected)."
}
],
"oculus": "mirror",
"opera": "mirror",
"opera_android": "mirror",
Expand All @@ -300,46 +324,6 @@
"standard_track": true,
"deprecated": false
}
},
"reject_pending_read_request": {
"__compat": {
"support": {
"chrome": {
"version_added": false,
"notes": "`releaseLock()` throws if there are pending read requests (rather than pending read requests being rejected)."
},
"chrome_android": "mirror",
"deno": {
"version_added": false
},
"edge": "mirror",
"firefox": {
"version_added": "102"
},
"firefox_android": "mirror",
"ie": {
"version_added": false
},
"nodejs": {
"version_added": false
},
"oculus": "mirror",
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": false
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror",
"webview_ios": "mirror"
},
"status": {
"experimental": true,
"standard_track": true,
"deprecated": false
}
}
}
}
}
Expand Down
110 changes: 55 additions & 55 deletions api/ReadableStreamDefaultReader.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,30 +225,70 @@
"mdn_url": "https://developer.mozilla.org/docs/Web/API/ReadableStreamDefaultReader/releaseLock",
"spec_url": "https://streams.spec.whatwg.org/#ref-for-default-reader-release-lock②",
"support": {
"chrome": {
"version_added": "43"
},
"chrome": [
{
"version_added": "105"
},
{
"version_added": "43",
"version_removed": "105",
"partial_implementation": true,
"notes": "The `releaseLock()` method would throw if there are pending read requests (rather than pending read requests being rejected)."
}
],
"chrome_android": "mirror",
"deno": {
"version_added": "1.0"
},
"deno": [
{
"version_added": "1.18"
},
{
"version_added": "1.0",
"version_removed": "1.18",
"partial_implementation": true,
"notes": "The `releaseLock()` method would throw if there are pending read requests (rather than pending read requests being rejected)."
}
],
"edge": "mirror",
"firefox": {
"version_added": "65"
},
"firefox": [
{
"version_added": "102"
},
{
"version_added": "65",
"version_removed": "102",
"partial_implementation": true,
"notes": "The `releaseLock()` method would throw if there are pending read requests (rather than pending read requests being rejected)."
}
],
"firefox_android": "mirror",
"ie": {
"version_added": false
},
"nodejs": {
"version_added": "16.5.0"
},
"nodejs": [
{
"version_added": "18.9.0"
},
{
"version_added": "16.5.0",
"version_removed": "18.9.0",
"partial_implementation": true,
"notes": "The `releaseLock()` method would throw if there are pending read requests (rather than pending read requests being rejected)."
}
],
"oculus": "mirror",
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": "10"
},
"safari": [
{
"version_added": "17"
},
{
"version_added": "10",
"version_removed": "17",
"partial_implementation": true,
"notes": "The `releaseLock()` method would throw if there are pending read requests (rather than pending read requests being rejected)."
}
],
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror",
Expand All @@ -259,46 +299,6 @@
"standard_track": true,
"deprecated": false
}
},
"reject_pending_read_request": {
"__compat": {
"support": {
"chrome": {
"version_added": false,
"notes": "`releaseLock()` throws if there are pending read requests (rather than pending read requests being rejected)."
},
"chrome_android": "mirror",
"deno": {
"version_added": false
},
"edge": "mirror",
"firefox": {
"version_added": "102"
},
"firefox_android": "mirror",
"ie": {
"version_added": false
},
"nodejs": {
"version_added": false
},
"oculus": "mirror",
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": false
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror",
"webview_ios": "mirror"
},
"status": {
"experimental": true,
"standard_track": true,
"deprecated": false
}
}
}
}
}
Expand Down
7 changes: 7 additions & 0 deletions browsers/nodejs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,6 +475,13 @@
"engine": "V8",
"engine_version": "10.1"
},
"18.9.0": {
"release_date": "2022-09-08",
"release_notes": "https://nodejs.org/en/blog/release/v18.9.0/",
"status": "retired",
"engine": "V8",
"engine_version": "10.1"
},
"18.13.0": {
"release_date": "2023-01-06",
"release_notes": "https://nodejs.org/en/blog/release/v18.13.0/",
Expand Down
Loading