-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chrome/Deno/Node/Safari started rejecting ReadableStream*Reader.releaseLock()
with pending read requests
#25516
base: main
Are you sure you want to change the base?
Chrome/Deno/Node/Safari started rejecting ReadableStream*Reader.releaseLock()
with pending read requests
#25516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and need to add an entry to https://github.com/mdn/browser-compat-data/blob/main/browsers/nodejs.json
reject_pending_read_request
and merge with releaseLock()
I went ahead and removed the I believe this removal is warranted under the rules for removing irrelevant features, but I'm open to discuss. Maybe @hamishwillee could chime in, as they added the feature in the first place in #16919? 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes up to d78a916 LGTM, but afaik we don't "merge" spec change subfeatures, partly because it makes the support history harder to read across browsers, and because there can be multiple spec changes that don't get implemented at the same time, which would make the notes even harder to understand.
reject_pending_read_request
and merge with releaseLock()
reject_pending_read_request
@caugner Fair enough, I've reverted the PR back to that commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, the data LGTM. Since the features now have good descriptions, we can now make the notes more concise.
"version_added": false, | ||
"notes": "`releaseLock()` throws if there are pending read requests (rather than pending read requests being rejected)." | ||
"version_added": "105", | ||
"notes": "Before version 105, `releaseLock()` would throw if there are pending read requests (rather than pending read requests being rejected)." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"notes": "Before version 105, `releaseLock()` would throw if there are pending read requests (rather than pending read requests being rejected)." | |
"notes": "Before version 105, `releaseLock()` throws instead of rejecting." |
"version_added": false, | ||
"notes": "`releaseLock()` throws if there are pending read requests (rather than pending read requests being rejected)." | ||
"version_added": "105", | ||
"notes": "Before version 105, `releaseLock()` would throw if there are pending read requests (rather than pending read requests being rejected)." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"notes": "Before version 105, `releaseLock()` would throw if there are pending read requests (rather than pending read requests being rejected)." | |
"notes": "Before version 105, `releaseLock()` throws instead of rejecting." |
reject_pending_read_request
ReadableStream*Reader.releaseLock()
with pending read requests
Summary
Update the compatibility data for
reject_pending_read_request
in bothReadableStreamDefaultReader
andReadableStreamBYOBReader
. See whatwg/streams#1168 for context. All major browsers now implement the new behavior.Test results and supporting details
ReadableStreamBYOBReader
, so I only updated the data forReadableStreamDefaultReader
.