Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tags for WebSocketStream #24913

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

skyclouds2001
Copy link
Contributor

Summary

the tags should be web-features:web-socket-stream, not web-features:web-features:web-socket-stream

maybe a replace bug introduced in #22875

see also https://websockets.spec.whatwg.org/ and whatwg/websockets#48

Test results and supporting details

Related issues

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 2, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review November 2, 2024 18:07
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

We should probably lint these eventually.

@caugner caugner merged commit 0b7db2a into mdn:main Nov 4, 2024
5 checks passed
@skyclouds2001
Copy link
Contributor Author

Good catch, thanks!

We should probably lint these eventually.

I guess it is possible to check if the tag is in https://github.com/web-platform-dx/web-features/

@skyclouds2001 skyclouds2001 deleted the WebSocketStream-tag branch November 4, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants