Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support lint "tags" field in BCD #24960

Closed
1 of 2 tasks
skyclouds2001 opened this issue Nov 5, 2024 · 1 comment
Closed
1 of 2 tasks

Support lint "tags" field in BCD #24960

skyclouds2001 opened this issue Nov 5, 2024 · 1 comment
Labels
linter Issues or pull requests regarding the tests / linter of the JSON files.

Comments

@skyclouds2001
Copy link
Contributor

What type of issue is this?

Linter issue

What is the issue?

Current the tags is mantually added by hand according to https://github.com/web-platform-dx/web-features/, but no lint will run for this field. This may cause some mistakes like: incorrect tag in #24913, or tag added to mismatched feature, or tag not added to matched feature.

What behavior were you expecting?

Support lint tags field in BCD. May need to check: whether the tag name s correct, whether the tag is added to the matched feature, whether the tag is not added to a matched feature, etc.

What version(s) of BCD is the issue present in?

  • The current BCD release
  • The current version of the main branch

Do you have anything more you want to share?

No response

@skyclouds2001 skyclouds2001 changed the title Support lint *tags* field in BCD Support lint "tags" field in BCD Nov 5, 2024
@queengooborg
Copy link
Contributor

queengooborg commented Nov 6, 2024

Those tags are actually added via a script, not manually added. The script in question already handles renames, deleted web features, etc.

More importantly, I don't think that BCD should be adding linting for web features tags. BCD doesn't control web features; it's a separate project.

@queengooborg queengooborg closed this as not planned Won't fix, can't repro, duplicate, stale Nov 6, 2024
@queengooborg queengooborg added the linter Issues or pull requests regarding the tests / linter of the JSON files. label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter Issues or pull requests regarding the tests / linter of the JSON files.
Projects
None yet
Development

No branches or pull requests

2 participants