Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: add test for 4S keys with no mac or iv #3048

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jan 22, 2024

A regression test for #2932.

Also adds a changelog entry.

@richvdh richvdh requested a review from a team as a code owner January 22, 2024 21:27
@richvdh richvdh requested review from Hywan and removed request for a team January 22, 2024 21:27
@richvdh richvdh force-pushed the rav/test_4s_key_with_no_mac branch from 0da4d92 to 68daa18 Compare January 22, 2024 21:43
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eec52d7) 83.67% compared to head (f14b183) 83.68%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3048   +/-   ##
=======================================
  Coverage   83.67%   83.68%           
=======================================
  Files         222      222           
  Lines       23293    23293           
=======================================
+ Hits        19491    19492    +1     
+ Misses       3802     3801    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

I wrote an angsty comment about what to name the test ;-)

@richvdh richvdh enabled auto-merge (squash) January 23, 2024 11:04
@richvdh richvdh merged commit ff89315 into main Jan 23, 2024
34 checks passed
@richvdh richvdh deleted the rav/test_4s_key_with_no_mac branch January 23, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants