Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valid 4S keys are ignored #2932

Closed
richvdh opened this issue Dec 11, 2023 · 6 comments · Fixed by #3046
Closed

Valid 4S keys are ignored #2932

richvdh opened this issue Dec 11, 2023 · 6 comments · Fixed by #3046

Comments

@richvdh
Copy link
Member

richvdh commented Dec 11, 2023

Per element-hq/element-web#26721, Element-Web R does not include the iv and mac properties on m.secret_storage.key.[key_id] account data objects. This causes Element X to ignore the key with: UnsupportedAlgorithm("m.secret_storage.v1.aes-hmac-sha2").

However, these properties are (and always have been) optional. The spec was recently clarified to say that, where they were missing, clients have to assume the key is valid.
@richvdh
Copy link
Member Author

richvdh commented Jan 18, 2024

ruma/ruma#1719 is my attempt at a first step here.

@Hywan
Copy link
Member

Hywan commented Jan 22, 2024

Great, thanks! Now that your PR on Ruma has been merge, do you need help to update the SDK?

@richvdh
Copy link
Member Author

richvdh commented Jan 22, 2024

Help would be appreciated, but I'll probably get to it eventually if you're busy.

Hywan added a commit to Hywan/matrix-rust-sdk that referenced this issue Jan 22, 2024
@Hywan
chore: Update Ruma to 684ffc.
bd2bdaf 
This patch updates Ruma to the latest commit on its `main` branch.

This is useful for matrix-org#2932.
@Hywan Hywan mentioned this issue Jan 22, 2024
Merged
@Hywan
Copy link
Member

Hywan commented Jan 22, 2024

I've updated Ruma to its latest commit on main in #3046. Hope it helps you a little bit.

Hywan added a commit to Hywan/matrix-rust-sdk that referenced this issue Jan 22, 2024
@Hywan
chore: Update Ruma to 684ffc.
eab35c1 
This patch updates Ruma to the latest commit on its `main` branch.

This is useful for matrix-org#2932.
@richvdh
Copy link
Member Author

richvdh commented Jan 22, 2024

Thanks! I think this is probably fixed by #3046, but we'd better test it to be sure.

richvdh added a commit that referenced this issue Jan 22, 2024
@richvdh
crypto: add test for 4S keys with no mac or iv
ba0d186 
A regression test for #2932
@richvdh richvdh mentioned this issue Jan 22, 2024
Merged
@richvdh
Copy link
Member Author

richvdh commented Jan 22, 2024

#3048 adds a test, so I'm reasonably happy this is now fixed.

@richvdh richvdh closed this as completed Jan 22, 2024
richvdh added a commit that referenced this issue Jan 23, 2024
@richvdh
crypto: add test for 4S keys with no mac or iv (#3048)
ff89315 
A regression test for #2932

Also a changelog update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Valid 4S keys are ignored Hywan/matrix-rust-sdk
2 participants
@Hywan @richvdh