Skip to content

Commit

Permalink
Merge pull request galaxyproject#2438 from ThomasWollmann/dev
Browse files Browse the repository at this point in the history
fixed $defaults according to galaxyproject#2430
  • Loading branch information
bgruening committed Jun 3, 2016
2 parents a0dbcb9 + 1695994 commit 697b01c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
3 changes: 2 additions & 1 deletion lib/galaxy/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -822,10 +822,11 @@ def _configure_toolbox( self ):
galaxy_root_dir = os.path.abspath(self.config.root)
file_path = os.path.abspath(getattr(self.config, "file_path"))
app_info = containers.AppInfo(
galaxy_root_dir,
galaxy_root_dir=galaxy_root_dir,
default_file_path=file_path,
outputs_to_working_directory=self.config.outputs_to_working_directory,
container_image_cache_path=self.config.container_image_cache_path,
library_import_dir=self.config.library_import_dir
)
self.container_finder = containers.ContainerFinder(app_info)

Expand Down
6 changes: 6 additions & 0 deletions lib/galaxy/tools/deps/containers.py
Original file line number Diff line number Diff line change
Expand Up @@ -152,12 +152,14 @@ def __init__(
default_file_path=None,
outputs_to_working_directory=False,
container_image_cache_path=None,
library_import_dir=None
):
self.galaxy_root_dir = galaxy_root_dir
self.default_file_path = default_file_path
# TODO: Vary default value for docker_volumes based on this...
self.outputs_to_working_directory = outputs_to_working_directory
self.container_image_cache_path = container_image_cache_path
self.library_import_dir = library_import_dir


class ToolInfo(object):
Expand Down Expand Up @@ -295,6 +297,7 @@ def add_var(name, value):
add_var("tool_directory", self.job_info.tool_directory)
add_var("galaxy_root", self.app_info.galaxy_root_dir)
add_var("default_file_path", self.app_info.default_file_path)
add_var("library_import_dir", self.app_info.library_import_dir)

if self.job_info.job_directory:
# We have a job directory, so everything needed (excluding index
Expand All @@ -307,6 +310,9 @@ def add_var(name, value):
else:
defaults = "$galaxy_root:ro,$tool_directory:ro,$working_directory:rw,$default_file_path:rw"

if self.app_info.library_import_dir:
defaults += ",$library_import_dir:ro"

# Define $defaults that can easily be extended with external library and
# index data without deployer worrying about above details.
variables["defaults"] = string.Template(defaults).safe_substitute(variables)
Expand Down

0 comments on commit 697b01c

Please sign in to comment.