Will M - Chitter #223
Open
Will M - Chitter #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,9 +1,28 @@ | |||
| require 'sinatra/base' | |||
| require "./lib/peep" | |||
|
|
|||
| class Chitter < Sinatra::Base | |||
| get '/test' do | |||
There was a problem hiding this comment.
You can probably delete this test route
|
|
||
| class Chitter < Sinatra::Base | ||
| get '/test' do | ||
| 'Test page' | ||
| end | ||
|
|
||
| get "/" do |
| end | ||
| end | ||
|
|
||
| def self.sort_by_date |
There was a problem hiding this comment.
If you kept working on this and wanted to add a new feature to sort by something other than date, could you refactor this method to be more flexible?
|
|
||
| describe Peep do | ||
|
|
||
| describe "::create" do |
There was a problem hiding this comment.
this should be .create not ::create
|
This is a nice solution and it clearly demonstrates the learning objectives around writing to and reading from a db. The next step would be to add filtering – if you had more time, would you know how to get started? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your name
William Marshall
User stories
Please list which user stories you've implemented (delete the ones that don't apply).
README checklist
Does your README contains instructions for
Here is a pill that can help you write a great README!