Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: after setting the cursor theme, it will not update in real-time. #268

Closed
wants to merge 1 commit into from

Conversation

mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Jan 6, 2025

Monitor the Gtk/CursorThemeName property and manually call changeCursor() to refresh the cursor when it changes

pms: BUG-296269

Monitor the Gtk/CursorThemeName property and manually call
changeCursor() to refresh the cursor when it changes

pms: BUG-296269
@mhduiy mhduiy requested a review from 18202781743 January 6, 2025 09:45
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot added a commit to linuxdeepin/qt6platform-plugins that referenced this pull request Jan 6, 2025
Synchronize source files from linuxdeepin/qt5platform-plugins.

Source-pull-request: linuxdeepin/qt5platform-plugins#268
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • cursorThemePropertyChanged 函数中的 Q_UNUSED 宏用于忽略未使用的参数,但应该确保这些参数在未来的代码维护中不会被误用。
  • QMetaObject::invokeMethod 使用了 Qt::QueuedConnection,这可能会导致界面响应延迟,应该评估是否需要立即更新。
  • VtableHook::callOriginalFun 函数的调用可能存在潜在的线程安全问题,需要确保在调用时线程安全。
  • xSettings()->registerCallbackForProperty 注册了一个回调函数,但没有提供回调函数的取消注册机制,可能会导致内存泄漏。

是否建议立即修改:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants