Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/qt5platform-plugins #60

Closed
wants to merge 1 commit into from

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/qt5platform-plugins.

Source-pull-request: linuxdeepin/qt5platform-plugins#268

Synchronize source files from linuxdeepin/qt5platform-plugins.

Source-pull-request: linuxdeepin/qt5platform-plugins#268
@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • cursorThemePropertyChanged 函数中的 Q_UNUSED 宏用于忽略未使用的参数,但应该明确注释说明为什么这些参数未使用。
  • cursorThemePropertyChanged 函数中的 QMetaObject::invokeMethod 使用了 Qt::QueuedConnection,这可能会导致界面响应延迟,应该评估是否需要立即更新。
  • VtableHook::callOriginalFun 函数的使用可能存在潜在的安全风险,需要确保 window->screen()->handle()->cursor() 返回的指针是有效的,并且 QPlatformCursor::changeCursor 函数指针也是正确的。
  • xSettings()->registerCallbackForProperty 函数的调用应该检查 xSettings() 是否为空,以避免潜在的空指针解引用。

是否建议立即修改:

@18202781743 18202781743 closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants