TW-1766: fix 500,404 error in POST request when login #1946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherlockvn
requested review from
hoangdat,
dab246,
nqhhdev,
hieutbui,
tddang-linagora and
Te-Z
as code owners
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/1946 |
Te-Z
approved these changes
Jul 11, 2024
|
Tested on android, chrome, edge, firefox. LGTM |
|
For this ticket, please note the cases we use to test
Please add more cases, we should maintain these test case to verify problem of backup. |
|
case 1: Screen.Recording.2024-07-12.at.11.33.59.mov |
|
case 2: Screen.Recording.2024-07-12.at.11.46.24.mov |
|
case 3: import backup key from mobile Screen.Recording.2024-07-12.at.11.58.52.mov |
Te-Z
reviewed
Jul 13, 2024
sherlockvn
force-pushed
the
TW-1766/cannot-decrypt-message-when-log-in
branch
from
f52b164 to
304439a
Compare
Te-Z
approved these changes
Jul 15, 2024
sherlockvn
changed the title
nqhhdev
reviewed
Jul 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Related issue
#1766
Root cause
If this is a bug, please provide a brief description of the root cause of the issue
We create the bootstrap dialog at the wrong time, so the state of bootstrap dialog always be
newSSSSKey, that means, it will call to POST request to upload new key no matter what even when you have got the recovery key success before in tom server.Solution
Outline the implemented solution, detailing the changes made and how they address the issue
The solution is direct. We move the creating bootstrap dialog after we have loaded successfully the roomData and accountData from homeserver. This will make sure that the bootstrap state is correct and will not call to upload recoveryKey everytime we log in.
Impact description
If this is not a bug, please explain how the changes affect the project
Can decrypt message with new account now.
Test recommendations
Recommendations for how to test this, or anything else you are worried about?
Pre-merge
Does anything else need to be done before merging?
no.
Resolved
Attach screenshots or videos demonstrating the changes
Screen.Recording.2024-07-11.at.16.06.51.mov
RPReplay_Final1720689551.MP4