Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move remainder of CI to github #10

Merged
merged 56 commits into from
Nov 14, 2024
Merged

Move remainder of CI to github #10

merged 56 commits into from
Nov 14, 2024

Conversation

brryan
Copy link
Collaborator

@brryan brryan commented Nov 8, 2024 •
edited
Loading

Convert gitlab PR and nightly workflows to github.

  • Get something working on GPUs.
  • Merge branch directly into develop to better test the result
  • Fix unpredictable advection test behavior
  • Stop creating unique run directories; create tst directory in executable location
  • Support --exe flag
  • Support automatically finding artemis executable in current directory
  • Support default usage of building a new executable
  • Have the advection test clean up its own history files

adamdempsey90
adamdempsey90 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@adamdempsey90 adamdempsey90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/ci.yml Outdated Show resolved Hide resolved
brryan added 24 commits November 8, 2024 15:49
@brryan
python dependencies
b4c1290
@brryan
different dependnecies approach
efc7a35
@brryan
No redundant doc jobs
4337870
@brryan
try getting nvidia on gpu runner
da94f1f
@brryan
Fewer nproc during make
20cf325
@brryan
Remove GPU jobs for now
d7962da
@brryan
Smaller disk problems
c8319c3
@brryan
Only change cartesian disk
d71d7a1
@brryan
Working on this
c4371f2
@brryan
Formatting
4fc31f5
@brryan
Only two ranks for MPI
32edddf
@brryan
Oops typo
46f1879
@brryan
Testing CPU count
1becc6e
@brryan
binary test takes too long on two slow ranks -- leave for GPU
9e661a0
@brryan
Oops missing os
b9b610b
@brryan
Update names
5c24d95
@brryan
Add slow version of parallel suite
fa64e71
@brryan
debug weird issue with cpu count
2f31a3d
@brryan
typo in debug prints
cbe5152
@brryan
New attempt at counting mpi slots
ddcc735
@brryan
Trying again with mpi oversubscribe
c036695
@brryan
OK lets just use oversubscribe
16c4c8c
@brryan
Change how run dir is created
c922286
@brryan
I need this branch to be up to date on github lol
17de819
brryan
brryan commented Nov 9, 2024
View reviewed changes
tst/run_tests.py Show resolved Hide resolved
pdmullen
pdmullen approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@pdmullen pdmullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, @brryan! 😸

tst/scripts/utils/artemis.py Outdated Show resolved Hide resolved
tst/suites/gpu.suite Show resolved Hide resolved
tst/suites/parallel.suite Show resolved Hide resolved
@adamdempsey90
Copy link
Collaborator

We should probably also fix the last sections of the README

@brryan
Copy link
Collaborator Author

brryan commented Nov 14, 2024

We should probably also fix the last sections of the README

Thanks for the reminder, fixed.

@brryan brryan merged commit 6496d7b into develop Nov 14, 2024
4 checks passed
@brryan brryan deleted the brryan/github_workflows branch November 14, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdempsey90 adamdempsey90 adamdempsey90 approved these changes

@pdmullen pdmullen pdmullen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brryan @adamdempsey90 @pdmullen