Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce mandatory module Label in module create #116

Merged
merged 7 commits into from
Dec 3, 2024
Merged

feat: Introduce mandatory module Label in module create #116

merged 7 commits into from
Dec 3, 2024

Conversation

medmes
Copy link
Member

@medmes medmes commented Dec 2, 2024

Description
Introduce Module template module label emabled

Changes proposed in this pull request:

  • Checking if Mandatory Module is enabled. if Yes append the label to true.
  • corespendent unit test.
  • corespendent e2e test.

Related issue(s)
#94

@medmes medmes requested a review from a team as a code owner December 2, 2024 15:17
@medmes medmes linked an issue Dec 2, 2024 that may be closed by this pull request
[Mandatory Modules] Introduce mandatory module Label in module create #94
Closed
4 tasks
c-pius
c-pius reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@c-pius c-pius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor and cosmetic things.

internal/service/templategenerator/templategenerator_test.go Outdated Show resolved Hide resolved
internal/service/templategenerator/templategenerator_test.go Outdated Show resolved Hide resolved
internal/service/templategenerator/templategenerator_test.go Show resolved Hide resolved
internal/service/templategenerator/templategenerator_test.go Outdated Show resolved Hide resolved
tests/e2e/create/create_test.go Outdated Show resolved Hide resolved
c-pius
c-pius approved these changes Dec 3, 2024
View reviewed changes
internal/service/templategenerator/templategenerator_test.go Outdated Show resolved Hide resolved
tests/e2e/create/create_test.go Outdated Show resolved Hide resolved
@kyma-bot kyma-bot added the lgtm label Dec 3, 2024
c-pius
c-pius requested changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@c-pius c-pius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentially approved, actually wanted two things to be addressed :)

@kyma-bot kyma-bot removed the lgtm label Dec 3, 2024
c-pius
c-pius previously approved these changes Dec 3, 2024
View reviewed changes
@kyma-bot kyma-bot added lgtm and removed lgtm labels Dec 3, 2024
@kyma-bot kyma-bot added the lgtm label Dec 3, 2024
@medmes medmes merged commit a473e00 into kyma-project:main Dec 3, 2024
10 checks passed
@medmes medmes deleted the mandatory_label_enabled branch December 3, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-pius c-pius c-pius approved these changes

Assignees

@c-pius c-pius

Labels
cla: yes lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Mandatory Modules] Introduce mandatory module Label in module create
3 participants
@medmes @c-pius @kyma-bot