Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mandatory Modules] Introduce mandatory module Label in module create #94

Closed
4 tasks done
lindnerby opened this issue Oct 31, 2024 · 0 comments · Fixed by #116
Closed
4 tasks done

[Mandatory Modules] Introduce mandatory module Label in module create #94

lindnerby opened this issue Oct 31, 2024 · 0 comments · Fixed by #116
Assignees
Labels
good first issue Good for newcomers

Comments

@lindnerby
Copy link
Member

lindnerby commented Oct 31, 2024

Description

Whenever create module is executed with module-config's mandatory: true, the resulting ModuleTemplate should also have the mandatory module label: operator.kyma-project.io/mandatory-module

Reasons

AC

  • module config like
    mandatory: true
    # ...
  • leads to ModuleTemplate like
    apiVersion: operator.kyma-project.io/v1beta2
    kind: ModuleTemplate
    metadata:
      name: template-operator-1.0.3
      namespace: kcp-system
      labels:
        "operator.kyma-project.io/mandatory-module": "true"
        # ...
  • functionality covered in unit tests
  • functionality covered in e2e tests

Attachments

@lindnerby lindnerby added the good first issue Good for newcomers label Oct 31, 2024
@medmes medmes self-assigned this Dec 2, 2024
@medmes medmes linked a pull request Dec 2, 2024 that will close this issue
@c-pius c-pius assigned c-pius and unassigned medmes Dec 3, 2024
@c-pius c-pius assigned medmes and unassigned c-pius Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants