Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proper error handling for polling hook #3434

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix: proper error handling for polling hook #3434

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/shared/hooks/BackendAPI/useGet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ const useGetHook = processDataFn =>
const currentRequestId = uuid();
const requestData = useRef({});
const previousRequestNotFinished = useRef(null);
const intervalIdRef = useRef(null);

const refetch = useCallback(
(isSilent, currentData) => async () => {
Expand Down Expand Up @@ -96,14 +97,22 @@ const useGetHook = processDataFn =>
[fetch, authData],
);

const cleanupPolling = useCallback(() => {
if (intervalIdRef.current) {
clearInterval(intervalIdRef.current);
intervalIdRef.current = null;
}
}, []);

useEffect(() => {
const receivedForbidden = error?.code === 403;

cleanupPolling();
// POLLING
if (!pollingInterval || receivedForbidden || skip) return;
const intervalId = setInterval(refetch(true, data), pollingInterval);
return _ => clearInterval(intervalId);
}, [path, pollingInterval, data, error, skip, refetch]);
intervalIdRef.current = setInterval(refetch(true, data), pollingInterval);
return cleanupPolling;
}, [path, pollingInterval, data, error, skip, refetch, cleanupPolling]);

useEffect(() => {
// INITIAL FETCH on path being set/changed
Expand Down
Loading