Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: proper error handling for polling hook #3434

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix: proper error handling for polling hook #3434

merged 1 commit into from
Oct 31, 2024

Conversation

chriskari
Copy link
Contributor

@chriskari chriskari commented Oct 28, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • outsourced polling functionality into custom hook with proper error handling

Related issue(s)
#3296

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 28, 2024
@chriskari chriskari linked an issue Oct 28, 2024 that may be closed by this pull request
Kubeconfigs with context names that include special characters brake Busola #3409
Closed
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 28, 2024
@chriskari chriskari removed a link to an issue Oct 28, 2024
Kubeconfigs with context names that include special characters brake Busola #3409
Closed
@chriskari chriskari linked an issue Oct 28, 2024 that may be closed by this pull request
The browser tab for the Busola dashboard is consuming 100% cpu after sometime of leaving it open #3296
Closed
@chriskari chriskari force-pushed the fix-cpu-consumption branch from 5659d16 to c5f2b5f Compare October 29, 2024 00:05
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 31, 2024
@dbadura dbadura merged commit b7acf6c into kyma-project:main Oct 31, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OliwiaGowor OliwiaGowor OliwiaGowor approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

Assignees

@OliwiaGowor OliwiaGowor

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The browser tab for the Busola dashboard is consuming 100% cpu after sometime of leaving it open
4 participants
@chriskari @OliwiaGowor @kyma-bot @dbadura