Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sig-testing] Add ci-kubernetes-e2e-kind-rootless #31085

Merged
merged 1 commit into from
Nov 16, 2023
Merged

[sig-testing] Add ci-kubernetes-e2e-kind-rootless #31085

merged 1 commit into from
Nov 16, 2023

Conversation

AkihiroSuda
Copy link
Member

The job runs kubetest2 with rootless kind: https://kind.sigs.k8s.io/docs/user/rootless/

kubetest2 is executed with "kindinv" (Kubernetes in (Rootless) Docker in (GCE) VM) driver: https://github.com/rootless-containers/kubetest2-kindinv

GCE VM (Ubuntu 22.04) is used for creating a host with cgroup v2 and systemd. Using KRTE was not an option, as it does not support systemd (discussed in #30744).

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 20, 2023
@k8s-ci-robot k8s-ci-robot requested review from chases2 and dims October 20, 2023 11:16
@AkihiroSuda AkihiroSuda mentioned this pull request Oct 20, 2023
Closed
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 20, 2023
@AkihiroSuda AkihiroSuda mentioned this pull request Oct 20, 2023
Open
@AkihiroSuda
Copy link
Member Author

/test ci-kubernetes-e2e-kind-rootless

(Does it work here?)

@k8s-ci-robot
Copy link
Contributor

@AkihiroSuda: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-test-infra-gubernator
  • /test pull-test-infra-integration
  • /test pull-test-infra-prow-checkconfig
  • /test pull-test-infra-prow-image-build-test
  • /test pull-test-infra-unit-test
  • /test pull-test-infra-verify-cri-o
  • /test pull-test-infra-verify-lint

The following commands are available to trigger optional jobs:

  • /test pull-test-infra-bazel
  • /test pull-test-infra-unit-test-race-detector-nonblocking

Use /test all to run the following jobs that were automatically triggered:

  • pull-test-infra-gubernator
  • pull-test-infra-prow-checkconfig
  • pull-test-infra-unit-test
  • pull-test-infra-unit-test-race-detector-nonblocking
  • pull-test-infra-verify-lint

In response to this:

/test ci-kubernetes-e2e-kind-rootless

(Does it work here?)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

AkihiroSuda
AkihiroSuda commented Oct 20, 2023
View reviewed changes
config/jobs/kubernetes/sig-testing/kubernetes-kind.yaml
set -eux
# kindinv: Kubernetes in (Rootless) Docker in (GCE) VM
# See https://github.com/rootless-containers/kubetest2-kindinv
(cd ; GO111MODULE=on go install github.com/rootless-containers/kubetest2-kindinv@master)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I can move the repo to https://github.com/kubernetes-sigs if there is an interest from SIG-testing)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BenTheElder you are more familiar with this area, I remember there was some discussion some time ago about external projects but I can't find it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

though, this is the installer or kubetest2 module, that is different, I think this is ok

@AkihiroSuda
Copy link
Member Author

/test pull-test-infra-unit-test-race-detector-nonblocking

@AkihiroSuda
[sig-testing] Add ci-kubernetes-e2e-kind-rootless
d9a65ea 
The job runs kubetest2 with rootless kind: https://kind.sigs.k8s.io/docs/user/rootless/

kubetest2 is executed with "kindinv" (Kubernetes in (Rootless) Docker in (GCE) VM) driver:
https://github.com/rootless-containers/kubetest2-kindinv

GCE VM (Ubuntu 22.04) is used for creating a host with cgroup v2 and systemd.
Using KRTE was not an option, as it does not support systemd (discussed in PR 30744).

Signed-off-by: Akihiro Suda <[email protected]>
@aojea
Copy link
Member

aojea commented Oct 24, 2023

/lgtm
/hold

holding on the resolution of this comment #31085 (comment)

/assign @BenTheElder

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2023
@AkihiroSuda
Copy link
Member Author

@BenTheElder PTAL 🙏

@aojea
Copy link
Member

aojea commented Nov 16, 2023 •
edited
Loading

/hold cancel
/lgtm
/approve

We can revisit later but I think that you have earned enough confidence along this years to be a trusted user and that repository looks well maintained

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AkihiroSuda, aojea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit ac22c2f into kubernetes:master Nov 16, 2023
@k8s-ci-robot
Copy link
Contributor

@AkihiroSuda: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kubernetes-kind.yaml using file config/jobs/kubernetes/sig-testing/kubernetes-kind.yaml

In response to this:

The job runs kubetest2 with rootless kind: https://kind.sigs.k8s.io/docs/user/rootless/

kubetest2 is executed with "kindinv" (Kubernetes in (Rootless) Docker in (GCE) VM) driver: https://github.com/rootless-containers/kubetest2-kindinv

GCE VM (Ubuntu 22.04) is used for creating a host with cgroup v2 and systemd. Using KRTE was not an option, as it does not support systemd (discussed in #30744).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AkihiroSuda
Copy link
Member Author

Thank you!

@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Nov 16, 2023 •
edited
Loading

Now I have to fix this
https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-kind-rootless/1725028351665508352

Activated service account credentials for: [[email protected]]
+ WRAPPED_COMMAND_PID=27
+ wait 27
+ /bin/bash -c 'set -eux
# kindinv: Kubernetes in (Rootless) Docker in (GCE) VM
# See https://github.com/rootless-containers/kubetest2-kindinv
(cd ; GO111MODULE=on go install github.com/rootless-containers/kubetest2-kindinv@master)
exec kubetest2 kindinv \
  --gcp-project=k8s-prow-builds \
  --gcp-zone=us-west1-b \
  --instance-image=ubuntu-os-cloud/ubuntu-2204-lts \
  --instance-type=n2-standard-4 \
  --kind-rootless \
  --build \
  --up \
  --down \
  --test=ginkgo \
  -- \
  --use-built-binaries \
  --focus-regex='\''\[NodeConformance\]'\'' \
  --skip-regex='\''\[Environment:NotInUserNS\]|\[Slow\]'\'' \
  --parallel=8
'
+ cd
+ GO111MODULE=on
+ go install github.com/rootless-containers/kubetest2-kindinv@master
go: downloading github.com/rootless-containers/kubetest2-kindinv v0.0.0-20231020110337-7d51deec8d1b
go: downloading github.com/octago/sflags v0.2.0
go: downloading sigs.k8s.io/kubetest2 v0.0.0-20231014151303-89f09b65e8dd
go: downloading github.com/spf13/pflag v1.0.5
go: downloading k8s.io/klog/v2 v2.100.1
go: downloading github.com/go-logr/logr v1.2.4
go: downloading github.com/spf13/cobra v1.7.0
go: downloading github.com/google/uuid v1.3.1
go: downloading github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
+ exec kubetest2 kindinv --gcp-project=k8s-prow-builds --gcp-zone=us-west1-b --instance-image=ubuntu-os-cloud/ubuntu-2204-lts --instance-type=n2-standard-4 --kind-rootless --build --up --down --test=ginkgo -- --use-built-binaries '--focus-regex=\[NodeConformance\]' '--skip-regex=\[Environment:NotInUserNS\]|\[Slow\]' --parallel=8
I1116 05:54:05.668129    1390 app.go:61] The files in RunDir shall not be part of Artifacts
I1116 05:54:05.668228    1390 app.go:62] pass rundir-in-artifacts flag True for RunDir to be part of Artifacts
I1116 05:54:05.668246    1390 app.go:64] RunDir for this run: "/home/prow/go/src/k8s.io/kubernetes/_rundir/501accad-33ec-4a94-bc6c-da13b28804dc"
I1116 05:54:05.672491    1390 app.go:130] ID for this run: "501accad-33ec-4a94-bc6c-da13b28804dc"
Error: stat /home/prow/go/src/github.com/kubernetes/kubernetes/_output/bin/e2e.test: no such file or directory (Hint: `make WHAT=test/e2e/e2e.test -C $(go env GOPATH)/src/github.com/kubernetes/kubernetes`)
+ EXIT_VALUE=1
+ set +o xtrace

@aojea
Copy link
Member

aojea commented Nov 16, 2023

not familiar with kubetest2 but it has

--use-built-binaries

and it fails to find the e2e.test binary, do you have to build it ?

@AkihiroSuda
Copy link
Member Author

Likely to be hitting "k8s.io/kubernetes" vs "kubernetes/kubernetes" issue

@AkihiroSuda
Copy link
Member Author

rootless-containers/kubetest2-kindinv#6 may have solved the issue, but hard to confirm locally with pj-on-kind.sh due to the dependency on GCP credentials

@AkihiroSuda
Copy link
Member Author

/test ci-kubernetes-e2e-kind-rootless

(Will it work here?)

This was referenced Nov 22, 2023
Closed
Closed
@AkihiroSuda
Copy link
Member Author

Opened a new issue to track the current CI failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea aojea left review comments

@chases2 chases2 Awaiting requested review from chases2

@dims dims Awaiting requested review from dims

Assignees

@BenTheElder BenTheElder

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AkihiroSuda @k8s-ci-robot @aojea @BenTheElder