Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add & remove functions for attributes #9

Merged
merged 1 commit into from
Jul 30, 2018
Merged

Add & remove functions for attributes #9

merged 1 commit into from
Jul 30, 2018

Conversation

MrSorcus
Copy link
Contributor

No description provided.

@kostya
Copy link
Owner

kostya commented Jul 30, 2018

looks ok, thanks, i not sure about edit attribute, how it should work. maybe as remove-add?

@MrSorcus
Copy link
Contributor Author

MrSorcus commented Jul 30, 2018

I think - yes.
But what about attribute_remove & attribute_delete?
Just add code like this?

  def attribute_remove(attr : MyhtmlTreeAttrT)
    Lib.attribute_remove(@node, attr)
  end

  def attribute_delete(attr : MyhtmlTreeAttrT)
    Lib.attribute_delete(@tree, @node, attr)
  end

@kostya
Copy link
Owner

kostya commented Jul 30, 2018

i not think this functions needed right now, because there is no MyhtmlTreeAttrT reference anyway (stored somewhere).

@kostya kostya merged commit 19b78ce into kostya:master Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants