Merge pull request #9 from MrSorcus/master

Add & remove functions for attributes
kostya · Jul 30, 2018 · 19b78ce · 19b78ce
2 parents 6c7839f + 2e788cc
commit 19b78ce
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 0 deletions.
diff --git a/spec/node_spec.cr b/spec/node_spec.cr
@@ -31,6 +31,22 @@ describe Myhtml::Node do
     node.attribute_by("class".to_slice).should eq "AAA".to_slice
   end
 
+  it "add attribute" do
+    parser = Myhtml::Parser.new("<html><body><div class=\"foo\">Haha</div></body></html>")
+
+    node = parser.nodes(:div).first
+    node.attribute_add("id", "bar")
+    node.attributes.should eq({"class" => "foo", "id" => "bar"})
+  end
+
+  it "remove attribute" do
+    parser = Myhtml::Parser.new("<html><body><div class=\"foo\" id=\"bar\">Haha</div></body></html>")
+
+    node = parser.nodes(:div).first
+    node.attribute_remove("id")
+    node.attributes.should eq({"class" => "foo"})
+  end
+
   it "ignore case attributes" do
     parser = Myhtml::Parser.new("<html><body><div Class=AAA STYLE='color:red'>Haha</div></body></html>")
 

diff --git a/src/myhtml/lib.cr b/src/myhtml/lib.cr
@@ -71,6 +71,14 @@ module Myhtml
     fun attribute_value = myhtml_attribute_value(attr : MyhtmlTreeAttrT*, length : LibC::SizeT*) : UInt8*
     fun attribute_next = myhtml_attribute_next(attr : MyhtmlTreeAttrT*) : MyhtmlTreeAttrT*
 
+    fun attribute_add = myhtml_attribute_add(node : MyhtmlTreeNodeT*, key : LibC::Char*, key_len : LibC::SizeT, value : LibC::Char*, value_len : LibC::SizeT, encoding : MyEncodingList) : MyhtmlTreeAttrT*
+
+    fun attribute_remove = myhtml_attribute_remove(node : MyhtmlTreeNodeT*, attr : MyhtmlTreeAttrT*) : MyhtmlTreeAttrT*
+
+    fun attribute_remove_by_key = myhtml_attribute_remove_by_key(node : MyhtmlTreeNodeT*, key : LibC::Char*, key_len : LibC::SizeT) : MyhtmlTreeAttrT*
+
+    fun attribute_delete = myhtml_attribute_delete(tree : MyhtmlTreeT*, node : MyhtmlTreeNodeT*, attr : MyhtmlTreeAttrT*) : Void
+
     fun serialization = myhtml_serialization(node : MyhtmlTreeNodeT*, str : MyhtmlStringRawT*) : MyStatus
     fun serialization_node = myhtml_serialization_node(node : MyhtmlTreeNodeT*, str : MyhtmlStringRawT*) : MyStatus
 

diff --git a/src/myhtml/node.cr b/src/myhtml/node.cr
@@ -122,6 +122,14 @@ module Myhtml
       end
     end
 
+    def attribute_add(key : String, value : String)
+      Lib.attribute_add(@node, key, key.bytesize, value, value.bytesize, Lib::MyEncodingList::MyENCODING_DEFAULT)
+    end
+
+    def attribute_remove(key : String)
+      Lib.attribute_remove_by_key(@node, key, key.bytesize)
+    end
+
     def attributes
       @attributes ||= begin
         res = {} of String => String