Introduction to moveable api (resolves #214) #215
Conversation
| @@ -22,6 +22,16 @@ describe('Moveable component', () => { | |||
| viewInstance.remove(); | |||
| } | |||
|
|
|||
| function mouseMoveTo(x, y) { | |||
There was a problem hiding this comment.
I would suggest to change this name to something like dragAndDropElement and would pass element there explicitly. It will be more generic then and name will describe, what this function actually mock.
There was a problem hiding this comment.
Since drag and drop has the same events name wouldn't it be confusing ?
There was a problem hiding this comment.
So maybe somthing like dragAndDropMock or something like that, because it in fact mock dragging and dropping, not only moving mouse.
|
Look pretty good, although I have few questions, suggestions. |
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
==========================================
+ Coverage 20.89% 21.65% +0.76%
==========================================
Files 21 20 -1
Lines 512 434 -78
==========================================
- Hits 107 94 -13
+ Misses 405 340 -65
Continue to review full report at Codecov.
|
| @@ -1,4 +1,5 @@ | |||
| import { Model } from '../../core'; | |||
| import { Model as BModel } from 'backbone'; | |||
There was a problem hiding this comment.
I would prefer to use more descriptive alias here - maybe BackboneModel?
|
I have some minnor question, but after getting some answers I'm going to merge it - we can make it better in future, but it takes us really lot of time and we need to speed up with development :). |
Palid
force-pushed
the
master
branch
4 times, most recently
from
616a0dd to
0e9bf2d
Compare
No description provided.