Run Kiali tests in OSSMC #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferhoyos
force-pushed
the
copy-kiali-tests
branch
from
8caee49 to
d5de326
Compare
ferhoyos
added
the
test: front-end/cypress
5 tasks
ferhoyos
force-pushed
the
copy-kiali-tests
branch
2 times, most recently
from
5fe65e0 to
a66f35f
Compare
ferhoyos
force-pushed
the
copy-kiali-tests
branch
from
5f436c3 to
7cfcf3e
Compare
|
testing via upstream-istio-pipeline/2165 |
| export CYPRESS_OC_CLUSTER_USER=<value> # defaults to jenkins, opt. kubeadmin | ||
| export CYPRESS_OC_CLUSTER_PASS=<value> # no defaults | ||
| export CYPRESS_OC_IDP=<value> # defaults to my_htpasswd_provider | ||
| export CYPRESS_USERNAME=<value> # defaults to jenkins, opt. kubeadmin |
There was a problem hiding this comment.
Originally I chose different variable names to be double sure that settings from kiali/kiali will not interfere with OSSMC suite. This is no longer a concern
ScriptingShrimp
approved these changes
Sep 19, 2024
| 'cypress-react-selector': { | ||
| root: '#root' | ||
| }, | ||
| OSSMC: true, |
There was a problem hiding this comment.
only nitpick, but this is why I would prefer to have two different configs, so there is no risk for them to be overwritten when copying the code
There was a problem hiding this comment.
Actually there are two configs, the cypress.config from Kiali repo and cypress.config from OSSMC repo. What I don't see is to have two configs just for OSSMC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
When we reused Kiali's source code as the foundation for the OSSMC plugin, we assumed that Kiali's Cypress tests would also be valid for OSSMC. In that case, we only needed to create Cypress tests for specific OSSMC pages, such as the Istio config list page or specific navigation scenarios. However, recent issues (see issue #330) have shown that the same test scenarios can behave differently in Kiali and OSSMC.
To address this, we have modified the OSSMC Cypress test infrastructure to run the same Kiali test scenarios in OSSMC. We have introduced the
@ossmcCypress tag to run only those Kiali tests that are applicable to OSSMC (excluding multi-cluster, wizards, etc.).Actions performed to enable running Kiali tests:
USERNAME,PASSWD,AUTH_PROVIDER, etc.)@ossmcCypress tag to include a Cypress test in the OSSMC test suite.@skip-ossmcCypress tag to exclude specific Cypress tests from features included in OSSMC.kialiandopenshiftfolders)visitandrequestCypress commands since there are slight differences in page URLs and APIs between Kiali and OSSMC.Steps to test the PR
yarn cypress:runand verify that OSSMC cypress test passIssue reference
#356