Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.73] Replace default cypress env variables #376

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

ferhoyos
Copy link
Collaborator

Describe the change

Partial backport of #357 where we replace the default user, password and auth provider cypress environment variables.

Steps to test the PR

Verify that the Cypress tests run successfully

Issue reference

#356

@ferhoyos ferhoyos self-assigned this Sep 13, 2024
@ferhoyos ferhoyos added the test: front-end/cypress PR adds/updates front-end tests (unit and/or cypress automation ) label Sep 13, 2024
@ferhoyos ferhoyos changed the title Replace default cypress env variables [v1.73] Replace default cypress env variables Sep 19, 2024
@ferhoyos ferhoyos mentioned this pull request Sep 20, 2024
5 tasks
Copy link
Contributor

@ScriptingShrimp ScriptingShrimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ScriptingShrimp ScriptingShrimp merged commit 56ada7a into kiali:v1.73 Sep 20, 2024
2 checks passed
@ferhoyos ferhoyos deleted the ossmc-env-variables branch September 20, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test: front-end/cypress PR adds/updates front-end tests (unit and/or cypress automation )
Projects
Development

Successfully merging this pull request may close these issues.

2 participants