-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: support flag file _control/debug #38
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow, for example, .htaccess directives based on the existence of the _control/debug file, so we know if we have built in debug mode or not, for example: <IfFile /var/www/html/_control/debug> ... add extra logging </IfFile> _control/debug should be added to .gitignore on all sites
mcdurdin
added a commit
to keymanapp/help.keyman.com
that referenced
this pull request
Nov 1, 2024
Relates-to: keymanapp/keyman.com#494 Depends-on: keymanapp/shared-sites#38
mcdurdin
added a commit
to keymanapp/keymanweb.com
that referenced
this pull request
Nov 1, 2024
Relates-to: keymanapp/keyman.com#494 Depends-on: keymanapp/shared-sites#38
mcdurdin
added a commit
to keymanapp/api.keyman.com
that referenced
this pull request
Nov 1, 2024
Relates-to: keymanapp/keyman.com#494 Depends-on: keymanapp/shared-sites#38
Can we document for developers? |
darcywong00
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
|
mcdurdin
added a commit
that referenced
this pull request
Nov 1, 2024
* chore: support flag file _control/debug (#38) This will allow, for example, .htaccess directives based on the existence of the _control/debug file, so we know if we have built in debug mode or not, for example: <IfFile /var/www/html/_control/debug> ... add extra logging </IfFile> _control/debug should be added to .gitignore on all sites * fix: Account for TIER_TEST on CI runs (#35) * feat: Add optional 'description' field for meta description content 📓 (#34) * feat: Add optional 'description' field for meta description content * fix: Handle when pagedescription undefined --------- Co-authored-by: Darcy Wong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow, for example, .htaccess directives based on the existence of the _control/debug file, so we know if we have built in debug mode or not, for example:
_control/debug should be added to .gitignore on all sites.