Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support flag file _control/debug #38

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Nov 1, 2024

This will allow, for example, .htaccess directives based on the existence of the _control/debug file, so we know if we have built in debug mode or not, for example:

<IfFile /var/www/html/_control/debug>
 ... add extra logging
</IfFile>

_control/debug should be added to .gitignore on all sites.

This will allow, for example, .htaccess directives based on the
existence of the _control/debug file, so we know if we have built in
debug mode or not, for example:

<IfFile /var/www/html/_control/debug>
 ... add extra logging
</IfFile>

_control/debug should be added to .gitignore on all sites
@mcdurdin mcdurdin added this to the A18S14 milestone Nov 1, 2024
@mcdurdin mcdurdin added the chore label Nov 1, 2024
mcdurdin added a commit to keymanapp/help.keyman.com that referenced this pull request Nov 1, 2024
mcdurdin added a commit to keymanapp/keymanweb.com that referenced this pull request Nov 1, 2024
mcdurdin added a commit to keymanapp/api.keyman.com that referenced this pull request Nov 1, 2024
@darcywong00
Copy link
Contributor

Can we document for developers?
Maybe in https://github.com/keymanapp/keyman/tree/master/docs/websites

Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mcdurdin
Copy link
Member Author

mcdurdin commented Nov 1, 2024

Can we document for developers? Maybe in https://github.com/keymanapp/keyman/tree/master/docs/websites

keymanapp/keyman#12602

@mcdurdin mcdurdin merged commit c2dd18a into chore/v0.11 Nov 1, 2024
1 check passed
@mcdurdin mcdurdin deleted the chore/debug-flag branch November 1, 2024 04:07
mcdurdin added a commit that referenced this pull request Nov 1, 2024
* chore: support flag file _control/debug (#38)

This will allow, for example, .htaccess directives based on the
existence of the _control/debug file, so we know if we have built in
debug mode or not, for example:

<IfFile /var/www/html/_control/debug>
 ... add extra logging
</IfFile>

_control/debug should be added to .gitignore on all sites

* fix: Account for TIER_TEST on CI runs (#35)

* feat: Add optional 'description' field for meta description content 📓 (#34)

* feat: Add optional 'description' field for meta description content

* fix: Handle when pagedescription undefined

---------

Co-authored-by: Darcy Wong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants