Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: only display errors in debug mode, otherwise log to stderr #494

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Nov 1, 2024

Relates-to: keymanapp/shared-sites#38
Fixes: #457

@mcdurdin mcdurdin added this to the A18S14 milestone Nov 1, 2024
@mcdurdin mcdurdin added the chore label Nov 1, 2024
mcdurdin added a commit to keymanapp/help.keyman.com that referenced this pull request Nov 1, 2024
mcdurdin added a commit to keymanapp/keymanweb.com that referenced this pull request Nov 1, 2024
mcdurdin added a commit to keymanapp/api.keyman.com that referenced this pull request Nov 1, 2024
Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mcdurdin mcdurdin merged commit 59fe576 into master Nov 1, 2024
2 checks passed
@mcdurdin mcdurdin deleted the chore/457-display-errors branch November 1, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: PHP errors are being exposed on client side
2 participants