fix: allow numeric region subtags #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #244. Widens the field to support 3-digit numeric subtags. There may be other metadata we wish to support in the future, but this at least allows the database to build, and searches to return the keyboard in question, verified locally (no tests added at this point).
|
Does langtags.json need to be changed to include these? |
Perhaps it would be useful, but that's a bigger discussion I think? It would necessitate further changes to our usage of langtags.json and would potentially be a breaking change in how we import the data on this site |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #244.
Widens the field to support 3-digit numeric subtags. There may be other metadata we wish to support in the future, but this at least allows the database to build, and searches to return the keyboard in question, verified locally (no tests added at this point).