Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update mssql.Dockerfile server:2022-latest to newer pin #267

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

darcywong00
Copy link
Contributor

@darcywong00 darcywong00 commented Jan 29, 2025

Follows #217. Fixes #268

Attempting to get a fixed server:2022 image that will run on the new CI cluster (newer kernel).
So @tim-eves can progress on the staging site migration.

Locally, I run into an SQL exception in /tools/db/build/build.inc.php:153

        INSERT t_keyboard_language (
          keyboard_id,
          bcp47,
          language_id,
          region_id,
          script_id,
          description
        ) VALUES
              (N'cantonese_telex',
              N'yue-latn-001',
              N'yue',
              N'001',
              N'latn',
              N'Chinese, Yue');
Array
(
    [0] => 42000
    [1] => 2628
    [2] => [Microsoft][ODBC Driver 18 for SQL Server][SQL Server]String or binary data would be truncated in table 'keyboards.k0.t_keyboard_language', column 'region_id'. Truncated value: '00'.
    [3] => 01000
    [4] => 3621
    [5] => [Microsoft][ODBC Driver 18 for SQL Server][SQL Server]The statement has been terminated.
)
Failure: PDOException: SQLSTATE[42000]: [Microsoft][ODBC Driver 18 for SQL Server][SQL Server]String or binary data would be truncated in table 'keyboards.k0.t_keyboard_language', column 'region_id'. Truncated value: '00'. in /var/www/html/tools/db/build/build.inc.php:153

I suspect the region "001" is getting truncated to "00". But will have to chase separately...

(update)
This was fixed by #246 in master branch, so updating staging fixes the error.

Reverts #217

Attempting to get a fixed server:2022 image that will run on the new CI cluster (newer kernel).
@darcywong00 darcywong00 added this to the A18S20 milestone Jan 29, 2025
@darcywong00 darcywong00 changed the title fix: Unpin the sha of server:2022-latest fix: Update mssql.Dockerfile server:2022-latest to newer pin Jan 30, 2025
@mcdurdin
Copy link
Member

I suspect the region "001" is getting truncated to "00". But will have to chase separately...

#246

Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darcywong00 darcywong00 merged commit 1ff43aa into staging Jan 30, 2025
2 checks passed
@darcywong00 darcywong00 deleted the fix/unpin-sha branch January 30, 2025 06:12
darcywong00 added a commit that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants