Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently write "PySpark" rather than "Pyspark" #179

Merged
merged 4 commits into from
Dec 7, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion features/run.feature
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Feature: Run all starters
When I run the Kedro pipeline
Then I should get a successful exit code

# Pyspark starter has no pipelines therefore we don't run the Kedro pipeline.
# PySpark starter has no pipelines therefore we don't run the Kedro pipeline.
# This starter acts as a basic example of implementing pyspark with Kedro.
Scenario: Run a Kedro project created from pyspark
Given I have prepared a config file
Expand Down
4 changes: 2 additions & 2 deletions spaceflights-pandas-viz/hooks/post_gen_project.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def main(selected_add_ons):
# Get the selected add-ons from cookiecutter
selected_add_ons = "{{ cookiecutter.add_ons }}"

# Execute the script only if the Pyspark add-on is selected.
# Execute the script only if the PySpark add-on is selected.
# This ensures the script doesn't run with kedro new --starter but only with the add-ons flow option.
if "Pyspark" not in selected_add_ons and "Kedro Viz" in selected_add_ons:
if "PySpark" not in selected_add_ons and "Kedro Viz" in selected_add_ons:
main(selected_add_ons)
2 changes: 1 addition & 1 deletion spaceflights-pyspark-viz/cookiecutter.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"project_name": "Spaceflights Pyspark Viz",
"project_name": "Spaceflights PySpark Viz",
"repo_name": "{{ cookiecutter.project_name.strip().replace(' ', '-').replace('_', '-').lower() }}",
"python_package": "{{ cookiecutter.project_name.strip().replace(' ', '_').replace('-', '_').lower() }}",
"kedro_version": "{{ cookiecutter.kedro_version }}",
Expand Down
4 changes: 2 additions & 2 deletions spaceflights-pyspark-viz/hooks/post_gen_project.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def main(selected_add_ons):
# Get the selected add-ons from cookiecutter
selected_add_ons = "{{ cookiecutter.add_ons }}"

# Execute the script only if the Pyspark add-on is selected.
# Execute the script only if the PySpark add-on is selected.
# This ensures the script doesn't run with kedro new --starter but only with the add-ons flow option.
if "Pyspark" in selected_add_ons and "Kedro Viz" in selected_add_ons:
if "PySpark" in selected_add_ons and "Kedro Viz" in selected_add_ons:
main(selected_add_ons)
2 changes: 1 addition & 1 deletion spaceflights-pyspark/cookiecutter.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"project_name": "Spaceflights Pyspark",
"project_name": "Spaceflights PySpark",
"repo_name": "{{ cookiecutter.project_name.strip().replace(' ', '-').replace('_', '-').lower() }}",
"python_package": "{{ cookiecutter.project_name.strip().replace(' ', '_').replace('-', '_').lower() }}",
"kedro_version": "{{ cookiecutter.kedro_version }}",
Expand Down
4 changes: 2 additions & 2 deletions spaceflights-pyspark/hooks/post_gen_project.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def main(selected_add_ons):
# Get the selected add-ons from cookiecutter
selected_add_ons = "{{ cookiecutter.add_ons }}"

# Execute the script only if the Pyspark add-on is selected.
# Execute the script only if the PySpark add-on is selected.
# This ensures the script doesn't run with kedro new --starter but only with the add-ons flow option.
if "Pyspark" in selected_add_ons:
if "PySpark" in selected_add_ons:
main(selected_add_ons)