Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently write "PySpark" rather than "Pyspark" #179

Merged
merged 4 commits into from
Dec 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spaceflights-pandas-viz/hooks/post_gen_project.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def main(selected_tools):
# Get the selected tools from cookiecutter
selected_tools = "{{ cookiecutter.tools }}"

# Execute the script only if the Pyspark tool is selected.
# Execute the script only if the PySpark tool is not selected and the Kedro Viz tool is selected.
# This ensures the script doesn't run with kedro new --starter but only with the tools flow option.
if "Pyspark" not in selected_tools and "Kedro Viz" in selected_tools:
if "PySpark" not in selected_tools and "Kedro Viz" in selected_tools:
main(selected_tools)
2 changes: 1 addition & 1 deletion spaceflights-pyspark-viz/cookiecutter.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"project_name": "Spaceflights Pyspark Viz",
"project_name": "Spaceflights PySpark Viz",
"repo_name": "{{ cookiecutter.project_name.strip().replace(' ', '-').replace('_', '-').lower() }}",
"python_package": "{{ cookiecutter.project_name.strip().replace(' ', '_').replace('-', '_').lower() }}",
"kedro_version": "{{ cookiecutter.kedro_version }}",
Expand Down
4 changes: 2 additions & 2 deletions spaceflights-pyspark-viz/hooks/post_gen_project.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def main(selected_tools):
# Get the selected tools from cookiecutter
selected_tools = "{{ cookiecutter.tools }}"

# Execute the script only if the Pyspark tool is selected.
# Execute the script only if the PySpark and Kedro-Viz tool is selected.
# This ensures the script doesn't run with kedro new --starter but only with the tools flow option.
if "Pyspark" in selected_tools and "Kedro Viz" in selected_tools:
if "PySpark" in selected_tools and "Kedro Viz" in selected_tools:
main(selected_tools)
2 changes: 1 addition & 1 deletion spaceflights-pyspark/cookiecutter.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"project_name": "Spaceflights Pyspark",
"project_name": "Spaceflights PySpark",
"repo_name": "{{ cookiecutter.project_name.strip().replace(' ', '-').replace('_', '-').lower() }}",
"python_package": "{{ cookiecutter.project_name.strip().replace(' ', '_').replace('-', '_').lower() }}",
"kedro_version": "{{ cookiecutter.kedro_version }}",
Expand Down
4 changes: 2 additions & 2 deletions spaceflights-pyspark/hooks/post_gen_project.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def main(selected_tools):
# Get the selected tools from cookiecutter
selected_tools = "{{ cookiecutter.tools }}"

# Execute the script only if the Pyspark tool is selected.
# Execute the script only if the PySpark tool is selected.
# This ensures the script doesn't run with kedro new --starter but only with the tools flow option.
if "Pyspark" in selected_tools:
if "PySpark" in selected_tools:
main(selected_tools)