Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch external-dns back to official upstream #1762

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+20 −11
Open

Switch external-dns back to official upstream #1762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce3349a
Switch external-dns back to official upstream
ytsarev Oct 26, 2024
7c5964a
Add default region propagation to route53 and configurable log level
ytsarev Feb 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions chart/k8gb/templates/external-dns/external-dns.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ spec:
- --source=crd
- --domain-filter={{ .Values.k8gb.edgeDNSZone }} # will make ExternalDNS see only the hosted zones matching provided domain, omit to process all available hosted zones
- --policy=sync # enable full synchronization including record removal
- --log-level=debug # debug only
- --managed-record-types=A
- --managed-record-types=CNAME
- --managed-record-types=NS
Expand All @@ -46,14 +45,17 @@ spec:
cpu: "500m"
securityContext:
readOnlyRootFilesystem: true
{{- with .Values.externaldns.extraEnv }}
env:
- name: EXTERNAL_DNS_LOG_LEVEL
value: {{ .Values.externaldns.logLevel }}
{{- with .Values.externaldns.extraEnv }}
{{- toYaml . | nindent 10 }}
{{- end }}
{{- if .Values.route53.secret }}
{{- if not .Values.externaldns.extraEnv }}
env:
{{- end }}
{{- if and .Values.route53.enabled .Values.route53.region }}
- name: AWS_DEFAULT_REGION
value: {{ .Values.route53.region }}
{{- end }}
{{- if and .Values.route53.enabled .Values.route53.secret }}
- name: AWS_SHARED_CREDENTIALS_FILE
value: /.aws/credentials
volumeMounts:
Expand Down
7 changes: 7 additions & 0 deletions chart/k8gb/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,9 @@
"interval": {
"type": "string"
},
"logLevel": {
"type": "string"
},
"securityContext": {
"$ref": "#/definitions/ExternaldnsSecurityContext"
}
Expand Down Expand Up @@ -601,6 +604,10 @@
"type": "string",
"minLength": 2
},
"region": {
"type": "string",
"minLength": 2
},
"irsaRole": {
"oneOf": [
{
Expand Down
10 changes: 5 additions & 5 deletions chart/k8gb/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,11 @@ externaldns:
# -- extra volume mounts
extraVolumeMounts: []
# -- external-dns image repo:tag
# It is important to use the image from k8gb external-dns fork to get the full
# functionality. See links below
# https://github.com/k8gb-io/external-dns
# https://github.com/k8gb-io/external-dns/pkgs/container/external-dns
image: ghcr.io/k8gb-io/external-dns:v0.13.4-azure-ns-multiarch
image: registry.k8s.io/external-dns/external-dns:v0.15.1
# -- external-dns sync interval
interval: "20s"
# -- external-dns log level
logLevel: debug
securityContext:
# -- For more options consult https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.28/#securitycontext-v1-core
runAsUser: 1000
Expand Down Expand Up @@ -144,6 +142,8 @@ route53:
# this can be useful when IRSA is not present or when using say Azure cluster and Route53
# docs: https://github.com/kubernetes-sigs/external-dns/blob/master/docs/tutorials/aws.md#create-iam-user-and-attach-the-policy
secret: null
# -- AWS default region
region: us-west-1

ns1:
# -- Enable NS1 provider
Expand Down
Loading