-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch external-dns back to official upstream #1762
base: master
Are you sure you want to change the base?
Conversation
49dc278
to
150c3f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As commented on slack: https://cloud-native.slack.com/archives/C021P656HGB/p1730555833483909?thread_ts=1729982761.336259&cid=C021P656HGB
Version 0.15.0 can't create NS records. ThenewRecordSet
function would need to be adapted: https://github.com/kubernetes-sigs/external-dns/blob/master/provider/azure/azure.go#L339
This is the error that we see:
time="2024-11-02T13:52:30Z" level=info msg="Updating NS record named 'cloud' to 'gslb-ns-eu-cloud.k8gb.io;gslb-ns-us-cloud.k8gb.io' for Azure DNS zone 'k8gb.io'."
time="2024-11-02T13:52:30Z" level=error msg="Failed to update NS record named 'cloud' to 'gslb-ns-eu-cloud.k8gb.io;gslb-ns-us-cloud.k8gb.io' for DNS zone 'k8gb.io': unsupported record type 'NS'"
chart/k8gb/values.yaml
Outdated
# https://github.com/k8gb-io/external-dns | ||
# https://github.com/k8gb-io/external-dns/pkgs/container/external-dns | ||
image: ghcr.io/k8gb-io/external-dns:v0.13.4-azure-ns-multiarch | ||
image: registry.k8s.io/external-dns/external-dns:v0.15.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
image: registry.k8s.io/external-dns/external-dns:v0.15.0 | |
image: registry.k8s.io/external-dns/external-dns:v0.15.1 |
As discussed in slack and the community meeting, version 0.15.1 contains our upstream changes
150c3f8
to
f5994cb
Compare
Azure test is green with
|
Fixes k8gb-io#1744 Signed-off-by: Yury Tsarev <[email protected]>
Otherwise external-dns fails with to add records with ``` operation error Route 53: ListHostedZones, failed to resolve service endpoint, endpoint rule error, Invalid Configuration: Missing Region ``` Optimize env handling(avoid conditionals in templating) Make externaldns log level configurable Signed-off-by: Yury Tsarev <[email protected]>
f5994cb
to
55ef42e
Compare
aws route53 is green. NOTE I have to slightly modify the chart templates for smoother operations, mainly setting default aws region to avoid zone list failure
|
Fixes #1744
This one needs extensive testing with various edge DNS environments.
The initial local test with rfc2136 is successful.
e2e regression tests
HOW TO RUN CI
---By default, all the checks will be run automatically. Furthermore, when changing website-related stuff, the preview will be generated by the netlify bot.
Heavy tests
Add the
heavy-tests
label on this PR if you want full-blown tests that include more than 2-cluster scenarios.Debug tests
If the test suite is failing for you, you may want to try triggering
Re-run all jobs
(top right) with debug logging enabled. It will also make the print debug action more verbose.