Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spot] publish compressed hand_depth_in_hand_color_frame topic #117

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

mqcmd196
Copy link

@mqcmd196 mqcmd196 commented Feb 7, 2025

I use /spot/camera/hand_depth_in_hand_color_frame/image to manipulate objects. I want to publish a compressed version of it.

@github-actions github-actions bot added the spot label Feb 7, 2025
@mqcmd196
Copy link
Author

mqcmd196 commented Feb 7, 2025

@sktometometo Please review

@mqcmd196
Copy link
Author

I confirmed this patch works for 3 days. It is required in my manipulation demo

@k-okada k-okada merged commit eda19a3 into k-okada:spot_arm Feb 12, 2025
3 of 8 checks passed
@mqcmd196 mqcmd196 deleted the publish-compressed-hand-depth branch February 12, 2025 00:46
@k-okada
Copy link
Owner

k-okada commented Feb 12, 2025

BTW, Does the republish node suppport cnnection based pub/sub system? If they always subscribe image topic from spot_ros driver and compress them even if no one is subscribing it, then please consider publishing compressed image from spot_ros driver.

@mqcmd196
Copy link
Author

republish node suppport cnnection based pub/sub system

I think the republishnode doesn't support it.

If they always subscribe image topic from spot_ros driver and compress them even if no one is subscribing it, then please consider publishing compressed image from spot_ros driver.

Yes I think it is the correct way. I'll create the patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants