Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jsk_tools] Add test_env_hooks.test. #1590

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[jsk_tools] Add test_env_hooks.test. #1590

wants to merge 4 commits into from

Conversation

iory
Copy link
Member

@iory iory commented Jul 23, 2018

Related to #1472
This PR add tests for env_hooks's function such that rossetip and rossetmaster.

@iory iory requested a review from furushchev July 23, 2018 08:30
@furushchev furushchev mentioned this pull request Jul 23, 2018
Open
furushchev
furushchev reviewed Jul 23, 2018
View reviewed changes
Copy link
Member

@furushchev furushchev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! see #1472 (comment)

@iory iory force-pushed the test-env-hooks branch 2 times, most recently from dfcb818 to 1d1791a Compare July 24, 2018 12:47
@iory
Copy link
Member Author

iory commented Jul 25, 2018

@furushchev
Please review this PR whenever you have time.

furushchev
furushchev reviewed Jul 27, 2018
View reviewed changes
jsk_tools/test/sh/rossetip.sh Outdated
#!/bin/bash

_THIS_DIR=$(builtin cd "`dirname "${BASH_SOURCE[0]}"`" > /dev/null && pwd)
source $_THIS_DIR/../../env-hooks/99.jsk_tools.bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it valid both in devel space and install?

@iory iory force-pushed the test-env-hooks branch from 09e96b4 to fe055de Compare July 30, 2018 10:13
@k-okada
Copy link
Member

k-okada commented Aug 14, 2018

test is failing. @iory

++ catkin_test_results --verbose --all build

Full test results for 'jsk_tools/test_results/jsk_tools/rosunit-test_rossetip0.xml'

-------------------------------------------------

<?xml version="1.0" encoding="utf-8"?>

<testsuite errors="0" failures="1" name="unittest.suite.TestSuite" tests="1" time="0.649"><testcase classname="__main__.TestStdout" name="test_stdout" time="0.6487"><failure type="AssertionError">'' != '133.11.216.88'

  File "/usr/lib/python2.7/unittest/case.py", line 329, in run

    testMethod()

  File "/home/travis/ros/ws_jsk_common/src/jsk_common/jsk_tools/src/test_stdout.py", line 29, in test_stdout

    self.assertEqual(stdout.strip(), expected)

  File "/usr/lib/python2.7/unittest/case.py", line 513, in assertEqual

    assertion_func(first, second, msg=msg)

  File "/usr/lib/python2.7/unittest/case.py", line 506, in _baseAssertEqual

    raise self.failureException(msg)

</failure></testcase><system-out>&lt;![CDATA[



]]&gt;</system-out><system-err>&lt;![CDATA[



]]&gt;</system-err></testsuite>

-------------------------------------------------

Full test results for 'jsk_tools/test_results/jsk_tools/rosunit-test_rossetip1.xml'

-------------------------------------------------

<?xml version="1.0" encoding="utf-8"?>

<testsuite errors="0" failures="1" name="unittest.suite.TestSuite" tests="1" time="0.665"><testcase classname="__main__.TestStdout" name="test_stdout" time="0.6646"><failure type="AssertionError">'' != '192.168.96.20'

  File "/usr/lib/python2.7/unittest/case.py", line 329, in run

    testMethod()

  File "/home/travis/ros/ws_jsk_common/src/jsk_common/jsk_tools/src/test_stdout.py", line 29, in test_stdout

    self.assertEqual(stdout.strip(), expected)

  File "/usr/lib/python2.7/unittest/case.py", line 513, in assertEqual

    assertion_func(first, second, msg=msg)

  File "/usr/lib/python2.7/unittest/case.py", line 506, in _baseAssertEqual

    raise self.failureException(msg)

</failure></testcase><system-out>&lt;![CDATA[



]]&gt;</system-out><system-err>&lt;![CDATA[



]]&gt;</system-err></testsuite>

-------------------------------------------------

Full test results for 'jsk_tools/test_results/jsk_tools/rosunit-test_rossetmaster1.xml'

-------------------------------------------------

<?xml version="1.0" encoding="utf-8"?>

<testsuite errors="0" failures="1" name="unittest.suite.TestSuite" tests="1" time="0.763"><testcase classname="__main__.TestStdout" name="test_stdout" time="0.7630"><failure type="AssertionError">'http://4a98a885ca7c:44439/' != 'http://hrp2017v:10017'

  File "/usr/lib/python2.7/unittest/case.py", line 329, in run

    testMethod()

  File "/home/travis/ros/ws_jsk_common/src/jsk_common/jsk_tools/src/test_stdout.py", line 29, in test_stdout

    self.assertEqual(stdout.strip(), expected)

  File "/usr/lib/python2.7/unittest/case.py", line 513, in assertEqual

    assertion_func(first, second, msg=msg)

  File "/usr/lib/python2.7/unittest/case.py", line 506, in _baseAssertEqual

    raise self.failureException(msg)

</failure></testcase><system-out>&lt;![CDATA[



]]&gt;</system-out><system-err>&lt;![CDATA[



]]&gt;</system-err></testsuite>

-------------------------------------------------

Full test results for 'jsk_tools/test_results/jsk_tools/rosunit-test_rossetmaster0.xml'

-------------------------------------------------

<?xml version="1.0" encoding="utf-8"?>

<testsuite errors="0" failures="1" name="unittest.suite.TestSuite" tests="1" time="0.654"><testcase classname="__main__.TestStdout" name="test_stdout" time="0.6542"><failure type="AssertionError">'http://4a98a885ca7c:44163/' != 'http://localhost:11311'

  File "/usr/lib/python2.7/unittest/case.py", line 329, in run

    testMethod()

  File "/home/travis/ros/ws_jsk_common/src/jsk_common/jsk_tools/src/test_stdout.py", line 29, in test_stdout

    self.assertEqual(stdout.strip(), expected)

  File "/usr/lib/python2.7/unittest/case.py", line 513, in assertEqual

    assertion_func(first, second, msg=msg)

  File "/usr/lib/python2.7/unittest/case.py", line 506, in _baseAssertEqual

    raise self.failureException(msg)

</failure></testcase><system-out>&lt;![CDATA[



]]&gt;</system-out><system-err>&lt;![CDATA[



]]&gt;</system-err></testsuite>

@k-okada
Copy link
Member

k-okada commented Apr 25, 2019

@iory please fix to pass the travis

@iory iory force-pushed the test-env-hooks branch 2 times, most recently from 4e4236f to 4097894 Compare June 2, 2022 00:39
@iory iory force-pushed the test-env-hooks branch from 066486c to a461023 Compare June 10, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furushchev furushchev furushchev left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@iory iory

Labels
WaitForFeedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iory @k-okada @furushchev