-
Notifications
You must be signed in to change notification settings - Fork 7
feat: create SA in EKS based on aws.helmSa #49
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR depends on:
|
/assign @jstrachan |
/assign @rawlingsj |
that was me testing the chatops here. Is this running |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bf54bfc
to
4da165b
Compare
- if `jxRequirements.cluster.aws.helmSa` is true: create SA with annotations to bind to the IAM Role with convention: `arn:aws:iam::<accountId>:role/<clustername>-<namespace>-<saName>` - otherwise: don't create SA fix jenkins-x-labs/issues#17
jxRequirements.cluster.aws.helmSa
is true: create SA with annotations to bind to the IAM Role with convention:arn:aws:iam::<accountId>:role/<clustername>-<namespace>-<saName>
fix jenkins-x-labs/issues#17