Skip to content
This repository has been archived by the owner on Nov 11, 2020. It is now read-only.

feat: create SA in EKS based on aws.helmSa #150

Closed
wants to merge 1 commit into from

Conversation

gazal-k
Copy link
Contributor

@gazal-k gazal-k commented Mar 31, 2020

  • if jxRequirements.cluster.aws.helmSa is true: create SA with annotations to bind to the IAM Role with convention: arn:aws:iam::<accountId>:role/<clustername>-<namespace>-<saName>
  • otherwise: don't create SA

fix jenkins-x-labs/issues#17

@ghost ghost added the size/XS label Mar 31, 2020
@gazal-k
Copy link
Contributor Author

gazal-k commented Mar 31, 2020

related to jenkins-x-labs/jenkins-x-versions#49 and has the same dependencies

@gazal-k
Copy link
Contributor Author

gazal-k commented Mar 31, 2020

looks like the CI on this is using go1.14 and I suppose that's why the build is failing

- if `jxRequirements.cluster.aws.helmSa` is true: create SA with annotations to bind to the IAM Role with convention: `arn:aws:iam::<accountId>:role/<clustername>-<namespace>-<saName>`
- otherwise: don't create SA

fix jenkins-x-labs/issues#17
@ghost
Copy link

ghost commented Apr 1, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rawlingsj
You can assign the PR to them by writing /assign @rawlingsj in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gazal-k gazal-k changed the title feat: create SA in EKS based on aws.useIRSAAnnotations feat: create SA in EKS based on aws.helmSa Apr 1, 2020
@gazal-k
Copy link
Contributor Author

gazal-k commented Apr 2, 2020

/label work-in-progress

@gazal-k
Copy link
Contributor Author

gazal-k commented Apr 2, 2020

looks like this can't be merged yet. The USER-SUPPLIED VALUES: for jxl-boot chart doesn't have the whole jx-requirements.yaml. Only something like:

jxRequirements:
  bootConfigURL: https://github.com/org/environment-cluster-name-dev
  cluster:
    clusterName: cluster-name
    project: project
    provider: eks

@gazal-k
Copy link
Contributor Author

gazal-k commented Apr 2, 2020

I think I'll close this for now to avoid accidentally merging this

@gazal-k gazal-k closed this Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Another mechanism for IAM Roles for Service Account creation in EKS
1 participant