Added back the old logic for classpath elements

[amihaiemil]

This is for issue #48 .
Changes in commit 4411738 fixed issue #41 , however they broke the classpath elements look-up logic. With those changes, only the elements in the compile classpath are searched. (E.g. the example project (findbugs-annotations) didn't work because jar aspectjrt was runtime scoped. It worked fine when I made the jar compile scoped)

Fix Let the changes from commit 4411738 and also added back the old lookup logic (now they are combined, method classpath() returns both the artifacts found by our logic and those found by ${project.compileClasspathElements}.
Also, classpath() method now returns a collection of String filepaths, instead of Files, it's a bit lighter.

I tested and now it works for both the example projects (1 attached in issue #48 - findbugs-annotations and 1 attached in issue #41).

[amihaiemil]

@dmarkov This PR is for issue #48 .

[dmarkov]

@amihaiemil Thanks, someone will review your pull request soon

[dmarkov]

@dmzaytsev could you please review this pull request

[amihaiemil]

@dmzaytsev ping

[dmzaytsev]

@dmarkov please assign someone else
no time

[dmarkov]

@dmarkov please assign someone else
no time

@dmzaytsev -15 points to your rating :(

[dmarkov]

@dmarkov please assign someone else
no time

@dmzaytsev I will assign somebody else to this issue

[amihaiemil]

@krzyk Can you maybe ask the PM to assign this to you so we can move faster? : )

[krzyk]

@amihaiemil it is up to @yegor256 he is the architect here

[dmarkov]

@mkordas review this one please

[mkordas]

@amihaiemil I'm on it

[mkordas]

@amihaiemil sorry, somehow I've lost focus yesterday, back here again

[amihaiemil]

@mkordas no worries, haha : D

[mkordas]

@amihaiemil I need explanation on

Fix Let the changes from commit 4411738 and also added back the old lookup logic (now they are combined, method classpath() returns both the artifacts found by our logic and those found by ${project.compileClasspathElements}.

What is exactly done besides revert and changing return type to Collection<String>. You mention compileClasspathElement but I couldn’t find it.

[mkordas]

@amihaiemil see just one question

[amihaiemil]

@mkordas see this.classpathElements. That was added in that commit. And it is combined with the old logic in the last line of classpath(). elements.addAll(this.classpathElements).

[mkordas]

@amihaiemil thanks, looks good!

[mkordas]

@rultor merge

[rultor]

@rultor merge

@mkordas Thanks for your request. @yegor256 Please confirm this.

[amihaiemil]

@yegor256 Can you please see about this one? Thanks

[amihaiemil]

@yegor256 ping

[amihaiemil]

@yegor256 don't forget about this one, pls. Thanks

[amihaiemil]

@yegor256 ping

[mkordas]

@yegor256 please review this PR

[mkordas]

@yegor256 ping

[mkordas]

@yegor256 ping again

[amihaiemil]

@yegor256 ping

[mkordas]

@yegor256 ping

[mkordas]

@yegor256 ping one more time

[mkordas]

@yegor256 ping

[mkordas]

@yegor256 it's waiting for you 15 days already

[mkordas]

@yegor256 ping

[mkordas]

@yegor256 ping again

[amihaiemil]

@mkordas maybe we can write a script that pings every 24 hours, eh? :))

[mkordas]

@amihaiemil yeah, I'm not sure what else can we do here...

[mkordas]

@yegor256 please take a look at this PR

[mkordas]

@yegor256 ping

[mkordas]

@yegor256 ping again

[mkordas]

@yegor256 ping

[krzyk]

@yegor256 could we get this merged? This issue has been opened for quite long and it makes findbugs practically disabled in projects using few latest qulice releases.

[yegor256]

@rultor merge

[rultor]

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 9min)

[dmarkov]

@mkordas Thanks a lot, I just topped your account for 35 mins, transaction ID 5763c883b93e110349000bdc, total time was 670 hours and 1 min... extra minutes for review comments (c=20)... +35 to your rating, your total score is +5488

[dmarkov]

@rultor deploy pls

[rultor]

@rultor deploy pls

@dmarkov OK, I'll try to deploy now. You can check the progress here

[rultor]

@rultor deploy pls

@dmarkov Done! FYI, the full log is here (took me 7min)