AJC is not executed correctly

[krzyk]

After changes done in #41 (4411738) ajc doesn't weave the project that is using jcabi-maven-plugin.

Attached is an example project that does weaving in 4e3c15e and stops doing it in 4411738

The expected tail output for command:

mvn clean install assembly:single && java -cp target/findbugs-annotations-1.0-SNAPSHOT-jar-with-dependencies.jar com.qulice.foo.Main a b c

is:

[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 9.360 s
[INFO] Finished at: 2016-03-09T09:13:15+01:00
[INFO] Final Memory: 55M/532M
[INFO] ------------------------------------------------------------------------
ERROR StatusLogger No log4j2 configuration file found. Using default configuration: logging only errors to the console.
[a, b, c]
09:13:16.034 [main] ERROR com.qulice.foo.Main - #main(['a', 'b', 'c']): in 806.87µs

(without the 09:13:16.034 and in 806.87µs as it will vary).

But what I get is:

[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 8.827 s
[INFO] Finished at: 2016-03-09T09:15:19+01:00
[INFO] Final Memory: 46M/514M
[INFO] ------------------------------------------------------------------------
[a, b, c]

Notice the missing @Loggable aspect above, there is no ERROR com.qulice.foo.Main - #main(['a', 'b', 'c']).

This is blocking #46 and yegor256/qulice#706.

findbugs-annotations.zip

[krzyk]

@yegor256 could you dispatch this issue? It is blocking yegor256/qulice#706

[dmarkov]

@krzyk I will find a developer for the task soon...

[dmarkov]

@krzyk thanks for the report, I topped your acc for 15 mins, payment ID 79994251

[dmarkov]

@nesterov-n please pick this up, and keep in mind these instructions. Any technical questions - ask right here; This task's budget is 30 mins. This is exactly how much will be paid when the problem explained above is solved. See this for more information

[nesterov-n]

@krzyk Where can I find sample project to reproduce issue?

[krzyk]

@nesterov-n I've updated the issue with an example project

[nesterov-n]

@dmarkov please assign someone else

[dmarkov]

@dmarkov please assign someone else

@nesterov-n 30 points was deducted from your rating

[dmarkov]

@dmarkov please assign someone else

@nesterov-n got it, someone else will be assigned soon

[krzyk]

@yegor256 any chance to proceed with this one?

[yegor256]

@dmarkov pls assign @amihaiemil to this

[dmarkov]

@dmarkov pls assign @amihaiemil to this

@yegor256 OK @amihaiemil please proceed, this task is yours

[amihaiemil]

@krzyk I left 2 comments on the #41 and currently waiting for a reply there. There are 2 ways of dealing with this ticket.

1. If the changes in PR #41 Use Classpath provided by Maven Core for AJC command #42 fixed ticket AJC Classpath issue with Maven multi-modules project #41 but introduced a bug, then we should dig deeper and fix the bug in this ticket (and ticket AJC Classpath issue with Maven multi-modules project #41 should actually be closed by now)

and

2. If the changes in PR #41 Use Classpath provided by Maven Core for AJC command #42 did not fix ticket AJC Classpath issue with Maven multi-modules project #41 then I simply revert those changes, we close this ticket and ticket AJC Classpath issue with Maven multi-modules project #41 continues on. As you see from the 2 comments of mine, I suspect it's option nr 2)... if I don't get a reply from the original author in 1 or 2 days, I will revert his changes.

Br,
Mihai Andronache

[amihaiemil]

@dmarkov I created PR #51 for this issue. Please find a reviewer. Thanks.
cc: @krzyk

[dmarkov]

@dmarkov I created PR #51 for this issue. Please find a reviewer. Thanks.
cc: @krzyk

@amihaiemil OK

[amihaiemil]

@dmarkov I need more time. Waiting for Yegor's approval on the PR.

[dmarkov]

@dmarkov I need more time. Waiting for Yegor's approval on the PR.

@amihaiemil OK, no problem, take your time

[amihaiemil]

@yegor256 ping

[amihaiemil]

@yegor256 ping

[yegor256]

@amihaiemil I'm here

[amihaiemil]

@krzyk the pr has been merged and closed

[krzyk]

@amihaiemil When I try on a test project, I see only test classes (ending with Test) inside the unwoven directory, but no main classes.
I would expect to find main classes there, and test classes inside unwoven-test.

[amihaiemil]

@krzyk Are you sure? what project are you testing with? Last time I checked with the findbugs-annotations project it worked ok

[krzyk]

@amihaiemil yes, I'm sure. I'm testing on a project that inherits from jcabi-parent, and I override the version of the jcabi-maven-plugin. There are only junit classes in the unwoven directory.

[krzyk]

@amihaiemil findbugs-annotations doesn't have test clases

[amihaiemil]

@krzyk Ok, I'll have a look into it as soon as I have time

[krzyk]

@yegor256 can we release new version of jcabi-maven-plugin?

[krzyk]

@yegor256 sorry, it was too soon, let's wait for the second PR to merge

[amihaiemil]

@krzyk pr was closed, you can have a look

[amihaiemil]

@krzyk ping

[krzyk]

@amihaiemil thanks

[krzyk]

@yegor256 could we release a new version of jcabi-maven-plugin?

[yegor256]

@krzyk the latest is 0.14.1 and it has all recent changes

[amihaiemil]

@dmarkov this ticket is closed

[dmarkov]

@amihaiemil Many thanks! 30 mins were added to your account in Transaction ID AP-2M6747456B475322E (task took 1178 hours and 50 mins)

+30 added to your rating, current score is: +330